Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd version referenced in docs, manifests #924

Merged

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Jul 19, 2017

Description

Update remaining references in docs, manifests to etcdv3 images.

Fixes #313

Todos

  • Tests
  • Documentation
  • Release note

Release Note

The version of etcd included in the Calico kubeadm manifests has been revved to v3.1.10.

@caseydavenport caseydavenport added this to the Calico v2.4.0 milestone Jul 19, 2017
@caseydavenport caseydavenport added the release-note-required Change has user-facing impact (no matter how small) label Jul 19, 2017
@caseydavenport
Copy link
Member Author

@ozdanborne I revved for Mesos docs as well, I assume that should be fine...

@caseydavenport caseydavenport self-assigned this Jul 19, 2017
@ozdanborne
Copy link
Member

Interesting, advertise-client-urls isn't needed anymore?

@caseydavenport
Copy link
Member Author

@ozdanborne I need to test, but I don't think it was ever needed...

@caseydavenport
Copy link
Member Author

I was wrong, definitely needed :)

@ozdanborne
Copy link
Member

Yep. For the record:

docker run quay.io/coreos/etcd:v3.1.10 etcd --listen-client-urls http://0.0.0.0:2379
2017-07-20 23:37:00.719729 E | etcdmain: error verifying flags, --advertise-client-urls is required when --listen-client-urls is set explicitly. See 'etcd --help'.
2017-07-20 23:37:00.719784 E | etcdmain: When listening on specific address(es), this etcd process must advertise accessible url(s) to each connected client.

@caseydavenport caseydavenport merged commit 5596ec5 into projectcalico:master Jul 20, 2017
@caseydavenport caseydavenport deleted the rev-etcd-kubeadm branch July 20, 2017 23:46
@caseydavenport caseydavenport mentioned this pull request Jul 31, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants