Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DebugBPFMapRepinEnabled -> false #2827

Merged
merged 1 commit into from May 24, 2021
Merged

DebugBPFMapRepinEnabled -> false #2827

merged 1 commit into from May 24, 2021

Conversation

nelljerram
Copy link
Member

@nelljerram nelljerram commented May 24, 2021 •
edited by fasaxc

There are now no use cases where we need map repinning, so let's
disable it by default. After running with this for a while, if there
are no issues, we can remove the related code.

Release Note

In eBPF mode, disable Felix's BPF map repinning logic by default. This logic was intended to avoid the need to mount the BPF filesystem into the calico/node container but it was flawed because program maps are emptied by the kernel when they are not pinned.

DebugBPFMapRepinEnabled -> false
c3ba095 
There are now no use cases where we need map repinning, so let's
disable it by default.  After running with this for a while, if there
are no issues, we can remove the related code.
@nelljerram nelljerram requested a review from a team as a code owner May 24, 2021 14:06
@marvin-tigera marvin-tigera added this to the Calico v3.20.0 milestone May 24, 2021
@nelljerram
Copy link
Member Author

Thanks @fasaxc for the release note!

@nelljerram nelljerram merged commit a5d6453 into projectcalico:master May 24, 2021
@nelljerram nelljerram deleted the bpf-disable-repin branch May 24, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasaxc fasaxc fasaxc approved these changes

@tomastigera tomastigera Awaiting requested review from tomastigera

Assignees
No one assigned
Labels
docs-not-required release-note-required
Projects
None yet
Milestone
Calico v3.20.0
3 participants
@nelljerram @fasaxc @marvin-tigera