Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockerfile goversion for architectures. #418

Merged
merged 1 commit into from
Feb 13, 2023
Merged

update dockerfile goversion for architectures. #418

merged 1 commit into from
Feb 13, 2023

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Feb 7, 2023

Signed-off-by: yanggang gang.yang@daocloud.io

/kind cleanup

1 add go version to other architectures .
2 change the base image alpine to 3.17.

fix #417

Signed-off-by: yanggang <gang.yang@daocloud.io>
@frozenprocess
Copy link
Contributor

/sem-approve

@frozenprocess frozenprocess self-assigned this Feb 8, 2023
@frozenprocess
Copy link
Contributor

@yanggangtony, did you try building Calico with this go-build change to see if there are any errors or not?

@yanggangtony
Copy link
Contributor Author

yanggangtony commented Feb 8, 2023

did you try building Calico with this go-build change to see if there are any errors or not?
@frozenprocess
Hi , thanks for review.
Actually i known go-build is calico's outer inference , i saw that is the branch tag?
like

/calico/metadata.mk  , 
# The version of github.com/projectcalico/go-build to use.
GO_BUILD_VER = v0.78

I am also a newbie to calico community.

How did it test local code for that?

@frozenprocess
Copy link
Contributor

frozenprocess commented Feb 8, 2023

did you try building Calico with this go-build change to see if there are any errors or not?
@frozenprocess
Hi , thanks for review.
Actually i known go-build is calico's outer inference , i saw that is the branch tag?
like

/calico/metadata.mk  , 
# The version of github.com/projectcalico/go-build to use.
GO_BUILD_VER = v0.78

I am also a newbie to calico community.

Welcome!
I would highly recommend checking the #contributors channel in the Calico Users Slack group. It is the place to share, ask and connect with other devs and engineers to talk Calico!

How did it test local code for that?

It is pretty easy,

# clone https://github.com/projectcalico/calico
make image all CALICO_BUILD=myrepo/myimage:mytag

@yanggangtony
Copy link
Contributor Author

yanggangtony commented Feb 8, 2023

@frozenprocess
thanks for the patient.
I will test it recently and response my result here.
👌

@yanggangtony
Copy link
Contributor Author

yanggangtony commented Feb 9, 2023

1 first i build go-build in my local pc .
image

then get images about :
image

2 : build calico project
企业微信截图_e10e2989-c5b9-44bc-b6ea-bc6cfc5f764f
企业微信截图_3a7a5940-1b5f-4491-b7ab-a4f420b92bd2

image

when build arm image in my amd64 machine, docker buildx can not do it , it get error before pic.

so maybe i should found a arm64 machine to test that ? is that right? if that , then will also to search ppc64le and s390x 's matchine , that will become very difficult to test.
is there a good way to test cross image for calico build?

@frozenprocess
Copy link
Contributor

frozenprocess commented Feb 13, 2023

I ended up building each image individually

make image CALICO_BUILD=rezareza/go-build:latest
make image ARCH=arm64 CALICO_BUILD=rezareza/go-build:latest-arm64
make image ARCH=s390x CALICO_BUILD=rezareza/go-build:latest-s390x
make image ARCH=armv7 CALICO_BUILD=rezareza/go-build:latest-armv7
make image ARCH=ppc64le CALICO_BUILD=rezareza/go-build:latest

so maybe i should found a arm64 machine to test that ? is that right? if that , then will also to search ppc64le and s390x 's matchine , that will become very difficult to test.

Nope, QEMU should take care of it, but it seems like after the monorepo change the CALICO_BUILD argument is not correctly passed on, I have to dig deeper tho.

is there a good way to test cross image for calico build?

Seems like a no atm, but I'll review it if you can figure out why it's not happening 😈

Thank you for your contribution!

Copy link
Contributor

@frozenprocess frozenprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mgleung mgleung merged commit 6eac2f2 into projectcalico:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why not upgrade to golang:1.19.5 for all platforms?
3 participants