This repository has been archived by the owner on Nov 8, 2019. It is now read-only.
Env variable to disable/enable namespace isolation policy #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,6 +35,9 @@ | |||
| KUBE_API_ROOT = os.environ.get('KUBE_API_ROOT', | |||
| 'http://kubernetes-master:8080/api/v1/') | |||
|
|
|||
| # Allow the user to enable/disable namespace isolation policy | |||
| NAMESPACE_ISOLATION = os.environ.get('NAMESPACE_ISOLATION', 'true') | |||
There was a problem hiding this comment.
I think calling this NAMESPACE_ISOLATION is a bit confusing, since namespace isolation will still be in effect if policy is declared, just not when no policy is declared.
A more apt name might be something like "DEFAULT_POLICY", with options for "ns_isolation", "allow". This means we could potentially support multiple other default behaviors in the future.
| @@ -35,6 +35,9 @@ | |||
| KUBE_API_ROOT = os.environ.get('KUBE_API_ROOT', | |||
| 'http://kubernetes-master:8080/api/v1/') | |||
|
|
|||
| # Allow the user to enable/disable namespace isolation policy | |||
| DEFAULT_POLICY = os.environ.get('DEFAULT_POLICY', 'ns_isolation') | |||
There was a problem hiding this comment.
I think the default behavior should be no ns_isolation.
|
LGTM. You'll want to update the calico-docker docs to reflect this as well. https://github.com/projectcalico/calico-docker/blob/master/docs/kubernetes/KubernetesIntegration.md |
luke-mino-altherr
added a commit
that referenced
this pull request
Aug 26, 2015
Env variable to disable/enable namespace isolation policy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.