Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle removing node for migration controller #404

Merged
merged 1 commit into from Sep 6, 2019
Merged

Handle removing node for migration controller #404

merged 1 commit into from Sep 6, 2019

Conversation

song-jiang
Copy link
Member

Description

Handle removing node for migration controller. Logs from test

2019-09-06 10:48:48.169 [INFO][1] logutils.go 159: Setting node label to disable Flannel daemonset pod on ip-172-16-101-55.us-west-2.compute.internal.
2019-09-06 10:48:48.172 [ERROR][1] logutils.go 159: Error adding node labels to disable Flannel network and mark migration in process for node ip-172-16-101-55.us-west-2.compute.internal. error=nodes "ip-172-16-101-55.us-west-2.compute.internal" not found
2019-09-06 10:48:48.173 [INFO][1] logutils.go 159: Node ip-172-16-101-55.us-west-2.compute.internal has been removed, continue on to next node...

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

caseydavenport
caseydavenport reviewed Sep 6, 2019
View reviewed changes
pkg/controllers/flannelmigration/network_migrator.go Outdated
notFound, checkErr := n.CheckNotExists(m.k8sClientset)
if checkErr != nil {
log.WithError(checkErr).Errorf("Check existence of %s failed.", node.Name)
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: couldn't this just be a else if block?

caseydavenport
caseydavenport approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise LGTM

@song-jiang song-jiang merged commit 8705dbf into projectcalico:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
docs-not-required release-note-not-required
Projects
None yet
Milestone
No milestone
3 participants
@song-jiang @caseydavenport @marvin-tigera