Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle removing node for migration controller #404

merged 1 commit into from Sep 6, 2019


Copy link

song-jiang commented Sep 6, 2019


Handle removing node for migration controller. Logs from test

2019-09-06 10:48:48.169 [INFO][1] logutils.go 159: Setting node label to disable Flannel daemonset pod on
2019-09-06 10:48:48.172 [ERROR][1] logutils.go 159: Error adding node labels to disable Flannel network and mark migration in process for node error=nodes "" not found
2019-09-06 10:48:48.173 [INFO][1] logutils.go 159: Node has been removed, continue on to next node...


  • Tests
  • Documentation
  • Release note

Release Note

None required
notFound, checkErr := n.CheckNotExists(m.k8sClientset)
if checkErr != nil {
log.WithError(checkErr).Errorf("Check existence of %s failed.", node.Name)
} else {

This comment has been minimized.

Copy link

caseydavenport Sep 6, 2019


nit: couldn't this just be a else if block?

Copy link

caseydavenport left a comment

One nit otherwise LGTM

@song-jiang song-jiang force-pushed the song-jiang:song-f2c branch from 6ed25a7 to e45a3a3 Sep 6, 2019
@song-jiang song-jiang merged commit 8705dbf into projectcalico:master Sep 6, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
semaphoreci The build passed on Semaphore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.