Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetworkSet resource #1055

Merged
merged 1 commit into from Mar 11, 2019
Merged

Conversation

lmm
Copy link
Contributor

@lmm lmm commented Mar 6, 2019

Description

Add NetworkSet, which is the namespaced version of GlobalNetworkSet.

Unit tests pending.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Add NetworkSet resource. NetworkSets are the namespaced-equivalent of GlobalNetworkSet.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmm this looks great!

Could you squash your commits down to one? Then I'll merge!

@caseydavenport caseydavenport changed the title WIP - Add NetworkSet resource Add NetworkSet resource Mar 10, 2019
@caseydavenport caseydavenport merged commit a1cf8b8 into projectcalico:master Mar 11, 2019
@lmm lmm mentioned this pull request Mar 14, 2019
3 tasks
@lmm lmm deleted the lmm/RFE-118 branch March 14, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants