Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetworkSet resource #1055

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@lmm
Copy link
Member

commented Mar 6, 2019

Description

Add NetworkSet, which is the namespaced version of GlobalNetworkSet.

Unit tests pending.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Add NetworkSet resource. NetworkSets are the namespaced-equivalent of GlobalNetworkSet.
@caseydavenport
Copy link
Member

left a comment

@lmm this looks great!

Could you squash your commits down to one? Then I'll merge!

@caseydavenport caseydavenport changed the title WIP - Add NetworkSet resource Add NetworkSet resource Mar 10, 2019

@lmm lmm force-pushed the lmm:lmm/RFE-118 branch from 4a4ee65 to 6d40b0f Mar 10, 2019

@caseydavenport caseydavenport merged commit a1cf8b8 into projectcalico:master Mar 11, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@spikecurtis

This comment has been minimized.

Copy link
Member

commented on lib/backend/k8s/k8s.go in 6d40b0f Mar 12, 2019

@lmm I think you're missing

&apiv3.NetworkSetList{},

This comment has been minimized.

Copy link
Member Author

replied Mar 14, 2019

This comment has been minimized.

Copy link
Member

replied Mar 14, 2019

@lmm I'm pretty sure this requires a change to this repo, not projectcalico/calico

This comment has been minimized.

Copy link
Member Author

replied Mar 14, 2019

Sorry wrong link, I meant this: #1059

@lmm lmm referenced this pull request Mar 14, 2019

Merged

Fix missing networksets list #1059

0 of 3 tasks complete

@lmm lmm deleted the lmm:lmm/RFE-118 branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.