Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of parameters to validateBlocksize #468

Merged
merged 1 commit into from Apr 22, 2020
Merged

Fix order of parameters to validateBlocksize #468

merged 1 commit into from Apr 22, 2020

Conversation

tmjd
Copy link
Member

@tmjd tmjd commented Apr 20, 2020 •
edited by fasaxc

Description

Fixes: #467

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix incorrect check of CIDR block size in node startup script.

@tmjd tmjd changed the title Fix order of parameters Fix order of parameters to validateBlocksize Apr 20, 2020
fasaxc
fasaxc approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@fasaxc fasaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it'd be worth adding some UT so we can't make this mistake again

@fasaxc
Copy link
Member

fasaxc commented Apr 22, 2020

Let's merge so this gets into v3.14

@fasaxc fasaxc merged commit 28bcc6a into projectcalico:master Apr 22, 2020
@tmjd tmjd mentioned this pull request Apr 22, 2020
Merged
3 tasks
@caseydavenport caseydavenport added this to the Calico v3.14.0 milestone Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasaxc fasaxc fasaxc approved these changes

Assignees
No one assigned
Labels
docs-not-required release-note-required
Projects
None yet
Milestone
Calico v3.14.0
4 participants
@tmjd @fasaxc @caseydavenport @marvin-tigera