Fix problems with tag detection and PBR version setting #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing this: ValueError: git history requires a target version of pbr.version.SemanticVersion(3.9.2), but target version is pbr.version.SemanticVersion(3.8.4) when building networking-calico packages from a commit with multiple version tags. The context for that was releasing a particular patch version, 3.8.4, so the general fix is that when we know the version we're releasing, skip the autodetection logic and just use that version.
|
@caseydavenport I'm sorry, I just merged this one by mistake, thinking it was a different approved PR. Would still appreciate your review, and will obviously address any comments or markups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing this:
ValueError: git history requires a target version of
pbr.version.SemanticVersion(3.9.2), but target version is
pbr.version.SemanticVersion(3.8.4)
when building networking-calico packages from a commit with multiple
version tags.
The context for that was releasing a particular patch version, 3.8.4,
so the general fix is that when we know the version we're releasing,
skip the autodetection logic and just use that version.