Skip to content

Commit

Permalink
Fix trying to close vpplink on vpp segfault
Browse files Browse the repository at this point in the history
This patch removes the closing of the vpplink channel
when VPP fails to start as if err != nil, vpp will always
be nil.

Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
  • Loading branch information
sknat committed Apr 25, 2024
1 parent b318f64 commit e1eda4c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion vpp-manager/vpp_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,6 @@ func (v *VppRunner) runVpp() (err error) {
v.vpp = vpp
if err != nil {
terminateVpp("Error connecting to VPP: %v", err)
v.vpp.Close()
<-vppDeadChan
return fmt.Errorf("cannot connect to VPP after 10 tries")
}
Expand Down

0 comments on commit e1eda4c

Please sign in to comment.