Add support for split and merge workflow patterns #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sliverc
commented
Dec 11, 2018
•
sliverc
commented
- To split workflow a list of tasks is returned in jexl expression
- To merge multiple tasks of a workflow link to same flow
sliverc
changed the title
winged
reviewed
Dec 11, 2018
There was a problem hiding this comment.
I have the feeling that this is overall getting way too complex to still not have any documentation regarding the concepts. What I'd like to see is at least the following (in README, or linked somewhere):
- Data model and it's meaning (blueprint side vs. instance side)
- Documentation in the relevant tests: What's supposed to happen (from user perspective)?
added 4 commits
December 11, 2018 10:43
* To synchronize a list of tasks is returned in jexl expression * To merge multiple tasks of a workflow link to same flow
|
@winged I have added some comments in the test case. Concerning documentation this is an open issue on my side and will be my next task to follow up so I would rather do it in a another PR. Documentation PR will then provide example graphql files, describing of main models and expanding GraphQL schema documentation. |
winged
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.