Add new question type table supporting nested tables #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the lengthy PR but is a bit of an advanced feature. |
czosel
reviewed
Jan 29, 2019
|
Rebased to master and also made sure that only one new migrations is created. |
czosel
approved these changes
Jan 29, 2019
caluma/form/serializers.py
Outdated
| queryset=models.Document.objects, | ||
| many=True, | ||
| required=True, | ||
| help_text="List of document ids whereas one document is one row in the table", |
There was a problem hiding this comment.
Suggested change
| help_text="List of document ids whereas one document is one row in the table", | |
| help_text="List of document IDs, each representing one row in the table", |
There was a problem hiding this comment.
or probably even better: "List of document IDs representing the rows in the table"
| def update(self, instance, validated_data): | ||
| documents = validated_data.pop("documents") | ||
|
|
||
| # detach answers to its own family tree |
There was a problem hiding this comment.
The comment is confusing me a bit. Aren't we detaching answers from their old family tree and afterwards reattaching them to the new one?
There was a problem hiding this comment.
first they get deattached and attached again later on. I have added a comment whey they get attached to lower confusion.
* Introduce new answer type AnswerTable * A table format is represented by a form * A single row is represented as a document of question row form * JEXL expanded whereas a table answer is a list of dicts with question keys. * Introduce document family to allow access to a tree of documents introduced through table answer.
* Introduce new answer type AnswerTable * A table format is represented by a form * A single row is represented as a document of question row form * JEXL expanded whereas a table answer is a list of dicts with question keys. * Introduce document family to allow access to a tree of documents introduced through table answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keys.
introduced through table answer.