Implement meta-field key filtering #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-dynaMIX
changed the title
open-dynaMIX
force-pushed
the
filter_meta_by_key
branch
from
098f4b5
to
fea6182
Compare
open-dynaMIX
force-pushed
the
filter_meta_by_key
branch
from
fea6182
to
8d0b929
Compare
|
Do we want this filter for all models with a meta-field? |
|
I think this can be useful everywhere, yeah. |
czosel
approved these changes
Mar 8, 2019
This commit implements a "meta_HasKey"-filter. This is done in "MetaFilterSet" which is a subclass of "FilterSet". For this to work, the meta-field is now a "generic.GenericScalar()".
open-dynaMIX
force-pushed
the
filter_meta_by_key
branch
from
8d0b929
to
c717681
Compare
open-dynaMIX
changed the title
winged
approved these changes
Mar 8, 2019
czosel
added a commit
to czosel/ember-caluma
that referenced
this pull request
Mar 11, 2019
Since projectcaluma/caluma#318, the meta field returns an actual object instead of a JSONString.
czosel
added a commit
to czosel/ember-caluma
that referenced
this pull request
Mar 11, 2019
Since projectcaluma/caluma#318, the meta field returns an actual object instead of a JSONString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a "meta_HasKey"-filter.
For this to work, the meta-field is now a "generic.GenericScalar()".
This implementation is up for discussion and only implemented for Form.meta atm. If we decide that this is the way to go, we can implement it for the other models as well.