Add date question and answer #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
force-pushed
the
add-date-question
branch
2 times, most recently
from
d504cb7
to
a6fee1d
Compare
czosel
force-pushed
the
add-date-question
branch
from
a6fee1d
to
5e6e53e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315
Validations like min/max are intentionally left out, because date validations are typically not based on fixed dates, but on relative dates ("booking date can only be in the future", "due date is between 10 and 30 days from now"). In my opinion there is a general lack of flexibility with the current validation system that I'd like to address before adding any new "fixed" validations.