feat(caluma): Remove FormAnswer type #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @anehx |
open-dynaMIX
force-pushed
the
refactor_nested_answers
branch
from
449c780
to
1c68b83
Compare
czosel
reviewed
Jun 14, 2019
open-dynaMIX
force-pushed
the
refactor_nested_answers
branch
9 times, most recently
from
e41d837
to
be2c695
Compare
|
❤️ 💯 🔥 |
open-dynaMIX
force-pushed
the
refactor_nested_answers
branch
4 times, most recently
from
beb5e7c
to
082a7fa
Compare
This was referenced Jun 21, 2019
Closed
Merged
winged
reviewed
Jun 21, 2019
open-dynaMIX
force-pushed
the
refactor_nested_answers
branch
2 times, most recently
from
8ee4ec8
to
7b14383
Compare
open-dynaMIX
force-pushed
the
refactor_nested_answers
branch
from
7b14383
to
c8cd03a
Compare
There was a conceptual misunderstanding that led us to implement nested answers. Which in turn created performance and complexity issues. This commit removes the FormAnswer type. Additionally also all implementations of recursive lookups and form path handling (that only existed as a result of this misconception) are removed. There is a data migration that flattens the document tree. Closes projectcaluma#504 BREAKING CHANGE: - The FormAnswer type is removed and answers to a question in a sub-form do not have their own document. - In order to access parent questions from within a table-sub-question JEXL, there is no need to prefix the question_slug with `parent.` anymore. - The JEXL expression `rootForm` is replaced by `form`.
open-dynaMIX
force-pushed
the
refactor_nested_answers
branch
from
c8cd03a
to
c9de785
Compare
|
@winged Ready for review! |
sliverc
added a commit
to sliverc/caluma
that referenced
this pull request
Jul 30, 2019
* There is no need for answer_tree anymore as of projectcaluma#505 * parent doesn't exist and can be removed * requiredness does not to be inherited as a form question does actually have answers.
sliverc
added a commit
to sliverc/caluma
that referenced
this pull request
Jul 30, 2019
* There is no need for answer_tree anymore as of projectcaluma#505 * parent doesn't exist and can be removed * requiredness does not to be inherited as a form question does actually have answers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a conceptual misunderstanding that led us to implement
nested answers. Which in turn created performance and complexity
issues.
This commit removes the FormAnswer type. Additionally also all
implementations of recursive lookups and form path handling (that only existed
as a result of this misconception) are removed.
There is a data migration that flattens the document tree.
Closes #504
BREAKING CHANGE:
in a sub-form do not have their own document.
JEXL, there is no need to prefix the question_slug with
parent.anymore.
rootFormis replaced byform.