Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: scss import of ember-uikit/variables-theme fails #2378

Closed
derrabauke opened this issue Apr 17, 2023 · 3 comments
Closed

bug: scss import of ember-uikit/variables-theme fails #2378

derrabauke opened this issue Apr 17, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@derrabauke
Copy link
Contributor

While upgrading ember-uikit to v7.0.2 in our application, we get an error with ember-caluma trying to import ember-uikit/variables-theme.

Sass Syntax Error (SassCompiler) in /tmp/broccoli-386687qSLemuEE93xz/out-1547-funnel_funnel_styles//app/styles/@projectcaluma/ember-form.scss:1:9

Error: Can't find stylesheet to import.
  ╷
1 │ @import "ember-uikit/variables-theme";
  │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
  /tmp/broccoli-386687qSLemuEE93xz/out-1547-funnel_funnel_styles/app/styles/@projectcaluma/ember-form.scss 1:9  @import
  /tmp/broccoli-386687qSLemuEE93xz/out-1547-funnel_funnel_styles/app/styles/app.scss 15:9                       root stylesheet


Stack Trace and Error Report: /tmp/error.dump.cc482bcaf099c575478ec062991d9656.log

After the latest fix of ember-uikit, I guess the following line

@import "ember-uikit/variables-theme";

should be replaced by.

@import "ember-uikit";
@derrabauke derrabauke added the bug Something isn't working label Apr 17, 2023
@anehx anehx removed their assignment Apr 18, 2023
@anehx
Copy link
Contributor

anehx commented Apr 18, 2023

I don't think this is an issue of @projectcaluma/ember-form but an issue of the host app because multiple versions of ember-uikit are installed (because #2377 is not merged and released yet). Have you tried adding a resolution for ember-uikit?

@czosel
Copy link
Contributor

czosel commented Apr 18, 2023

I agree @anehx - unfortunately the resolution for ember-uikit doesn't seem to help. Ping me if you have a second to look at this together.

czosel added a commit to adfinis/ember-uikit that referenced this issue Apr 18, 2023
This fixes an issue introduced in #1048 where the ember-uikit styles are
only available for the build of the host app, but not for addons which
also use ember-uikit (e.g.
projectcaluma/ember-caluma#2378).
czosel added a commit to adfinis/ember-uikit that referenced this issue Apr 18, 2023
This fixes an issue introduced in #1048 where the ember-uikit styles are
only available for the build of the host app, but not for addons which
also use ember-uikit (e.g.
projectcaluma/ember-caluma#2378).
@czosel
Copy link
Contributor

czosel commented Apr 18, 2023

Solved in adfinis/ember-uikit#1050

@czosel czosel closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants