fix(navigation): fix navigation to show base form questions #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this now cause to render a navigation even if there are no subforms? How is it structured - are all subforms indented a bit more or is the main form on the same level? Could you append a screenshot? |
There is no navigation when there are no subforms
They are all on the same level
|
|
Now with a divider between main and sub form navigation points |
czosel
pushed a commit
that referenced
this pull request
Nov 6, 2019
# [3.0.0](v2.5.0...v3.0.0) (2019-11-06) ### Bug Fixes * **jexl:** allow falsey values for intersects operator without breaking ([4fbb73f](4fbb73f)) * **navigation:** fix navigation to show base form questions ([#565](#565)) ([5f38df0](5f38df0)), closes [#460](#460) * **table:** don't re-save existing rows after edit ([e5cd5ef](e5cd5ef)) * **table:** remove row documents on delete ([395e4e4](395e4e4)) * **table:** skip empty dates in table view ([97f5758](97f5758)) ### chore * remove support for ember 3.8 ([093d25b](093d25b)) ### Features * **form:** handle old values of dynamic questions ([c9bbc36](c9bbc36)) * **license:** switch license from MIT to LGPL-3.0-or-later ([b1163eb](b1163eb)) ### BREAKING CHANGES * **license:** Since the LGPL license is more restrictive than MIT, this is marked as breaking * **form:** This is a breaking change, since it will only work with v3.0.0 or later of the caluma service. * This will remove the support for the second last LTS version of ember, since we support only the last LTS version which is 3.12 now.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460