feat(models): (re)introduce some convenience methods for working with scope trees #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winged
changed the title
winged
force-pushed
the
feat_convenience_methods
branch
8 times, most recently
from
a9cc84b
to
7bbd61d
Compare
maria-pw
reviewed
Jun 12, 2024
… scope trees The Django-MPTT module provided some useful methods that are not available anymore with django-tree-queries. Luckily, it's relatively easy to provide workarounds. Note that they might not have the same performance/efficiency as the MPTT variants, and could possibly be built in a better way. However, let's keep it to the motto "first make it right, then fast, then pretty"
winged
force-pushed
the
feat_convenience_methods
branch
from
6d777d0
to
b96014f
Compare
|
LGTM |
maria-pw
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Django-MPTT module provided some useful methods that are not available anymore with django-tree-queries. Luckily, it's relatively easy to provide workarounds.
Note that they might not have the same performance/efficiency as the MPTT variants, and could possibly be built in a better way. However, let's keep it to the motto "first make it right, then fast, then pretty"