Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenny/gfx release ww24 #7

Merged
merged 21 commits into from
Jun 20, 2019

Conversation

jennycao
Copy link
Contributor

@jennycao jennycao commented Jun 19, 2019

Tracked-On:OAM-83195
Signed-off-by: Jenny Cao jenny.q.cao@intel.com

Shao-Feng and others added 20 commits May 27, 2019 11:10
Use the method drmAuthMagic to check if hwc is already DRM master
or not.

Change-Id: I1931017e1223ae550c52816e6b2a64c74bdf9190
Tests: Work well on celadon with kernel 4.19.19
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Add a null checking before dereferencing the pointer.

Test: Compile successful
Change-Id: Ib5e295b2d1f3416ab99f1a0fabf76013d7f8e002
Tracked-On: https://jira.devtools.intel.com/browse/OAM-80450
Sighed-off-by: Yuanzhe, Liu <yuanzhe.liu@intel.com>
For performance purpose

Change-Id: I152d3838003e2b4efddc2418057e42e49fc0bb8f
Tracked-On: https://jira.devtools.intel.com/browse/OAM-76069
Signed-off-by: Yang, Dong <dong.yang@intel.com>
Signed-off-by: Lin Johnson <johnson.lin@intel.com>
Print the timestamp for commiting the first frame after
DRM-Master is reset

Change-Id: I394916e7abf225539e3842dcce813373543ba1d6
Tests: Work well with KMSCube
Tracked-On: https://jira.devtools.intel.com/browse/OAM-79556
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Disable all not-in-used planed once DRM Master is reset.
To avoid that some surface will is committed by other APP
are remained.

Change-Id: Ia2b28303ea0eaa6deda46e6d3a8d7a04674ea394
Tests: Work well with Kmscube testing APP.
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Let HWC validate layers if visible layers changed from last frame
and initialize instances and their linkage of DisplayPlaneState
object and OverlayPlane object properly.

Change-Id: I3b6eba2ecec2ef8f3a06db50f8faea070d998604
Tests: Video playback control bar pop up without black flicker
Tracked-On: https://jira.devtools.intel.com/browse/OAM-72226
Signed-off-by: Wan Shuang <shuang.wan@intel.com>
When surface_damage is empty, it mean the layer is not changed.
the rendering area must be set as empty to avoid re-render a
unchanged layer.

Test: Work well for benchmark T-Rex and Manhattan.
Change-Id: I8abee7408b1338617d85e7af6696e42375e7d788
Tracked-On: https://jira.devtools.intel.com/browse/OAM-80208
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
plane_transform_ is verified in Overlaylayer with plane rotate and
hwclayer rotate. surface damage should be calculated according to
plane_transform_. A special case for rotate_180, the damage should
not be changed.
this commit is fix the rotate issue which is reproduced by the commit
bc2b7b5fd370b4490241bd36f704e79aa5b3dcb5
Remain issue: On rotate 180, cursor location is shown incorrectly.

Change-Id: I6a6117823228f3a7c77e0f028e676a7be1399d89
Tests: Work well on extend mode with rotate_90, 180 and 270
Tracked-On: https://jira.devtools.intel.com/browse/OAM-80208
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
More programs need to initialized, if the programe not
created enough, then some will be create at compostion
time, and will result in bad Janky Frame.

Change-Id: I64470f616777646d6c1d27846c8e7be0f7eb4a75
Test: Compile pass on Android, no regressions on 1A.
Tracked-On: https://jira.devtools.intel.com/browse/OAM-76069
Signed-off-by: Yang, Dong <dong.yang@intel.com>
Update validate_final_layers state to ensure HWC update plans'
status properly and make the plane squashing behavior works as
expected.

Change-Id: I5f5aa496e57753da6b6e72f82900461ca672d367
Test: External display is not hang during video playback
Tracked-On: None
Signed-off-by: Wan Shuang <shuang.wan@intel.com>
Defines HWC_LIMITED_MONITOR_LIST for limited monitors' name, and
only exposes the preferred mode for those monitors.

Tests: Works well with limited monitors (e.g. "TD2230 Series") and
       other normal monitor, and can get display name from debug
       log. limited monitor only exposes preferred mode to uplevel.

Tracked-On: OAM-78920
Signed-off-by: Yugang Fan <yugang.fan@intel.com>

Change-Id: Ic8bf86c4ea7fdc98de48fb54da669172425afe0b
For avoiding to impact the alpha of layer in case that solid_color
is not set.

Change-Id: I2030165839a9c7f371fed6f81279ac2d94db084e
Tests: Work well on GP-P
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Revert "Fixed the external display hang during video playback."
Revert "Fixed the black stripe issue during video playback control bar popup"

Change-Id: I2638468a04518ba9f45209eb5a8486a8de86b99d
Tests: Video playback with 2 displays and check plane & layer binding.
Tracked-On: None
Signed-off-by: Wan Shuang <shuang.wan@intel.com>
Fix errors in gordon_peak 63 daily klocwork scanning.

Test: Compile successful
Tracked-On: No
Sighed-off-by: Yuanzhe, Liu <yuanzhe.liu@intel.com>
Change-Id: I8ad955264e1438cb592f99fc16d49fb8e3c61ff8
RBC will be disabled when 2 or more displays are connected

Change-Id: I8944fb7070c99fad30732077f06b4c9e5e2bacd3
Tests: RBC only enabled with 1 connected display
Tracked-On: intel/IA-Hardware-Composer#585
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Video Plane is now scaled by VPP, instead of Display Plane any
more. No need to re-validate Video Plane for scaler.

Change-Id: I870ab3d7ecf966180f83552e13d7f05885cb34e5
Tests: Work well on extend mode with rotate in Playing video
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
When 'SetSurfaceDamage' is invoked without damage, surface_damage
should not be rotated too. and For 180 case, the size should be
rotated too for SF-rotation.

Change-Id: I231a08de6fb5017bca60f8be02146fb2a0a06e33
Tests: Work well on extend mode with rotate_90, 180 and 270
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
In SF rotation, display_frame and surface are already rotated from
SF. we need to split the rotation status for HWC and SF into
transform_ and plane_transform_ for deciding if display_frame and
surface need to be rotated. and add an property for merged rotation
for rotate surface_damage.

Change-Id: I0ce8522c2a9807d4194d0a8b8334b0f984def2b6
Tests: Work well in SF rotation on GP P and Q
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Add an API in binder for dropping and setting DRM master

Test: Compile sucessful for Android.
Change-Id: Iad5df43ad26e9d063aac339e79394b4f00e8431d
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
In "Presentation with Media Router" test case, the surface-damage
for the changing layer on extend display is 0. For work around it
HWC will mark "content is changed" for all layers on extend display

Change-Id: I048b56e967a6f06ba73eff5ae77c95a55cbd028c
Tests:         Tested on Android Q
Tracked-On:    None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckApprovals Some checks are failed. See the step results.html

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/576

@jennycao jennycao requested a review from js0701 June 19, 2019 08:04
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autobuild started from pull-request-changes on this PR.

FAILURE: CheckBug Bad comments/Bugs

For more information, see: /absp/builders/celadon-autobuild/builds/985

Merge branch 'upstream_ww24' into jenny/gfx_release_ww24

Tracked-On:OAM-83195
Signed-off-by: Jenny Cao <jenny.q.cao@intel.com>
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckBug Bad comments/Bugs

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/582

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:CheckApprovals Some checks are failed. See the step results.html

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/583

@jennycao jennycao requested a review from js0701 June 19, 2019 14:42
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:Trigger Builds Triggered: build-cel - r1 (cel_apl), build-cel - r1 (cel_kbl), build-cel - r1 (celadon), build-cel - r1 (clk), build-cel - r2 (r2_cel_apl), build-cel - r2 (r2_cel_kbl), build-cel - r2 (r2_celadon), build-cel - r2 (r2_clk)

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/586

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure when executing preintegration builder

FAILURE:Trigger Builds Triggered: build-cel - r1 (cel_apl), build-cel - r1 (cel_kbl), build-cel - r1 (celadon), build-cel - r1 (clk), build-cel - r2 (r2_cel_apl), build-cel - r2 (r2_cel_kbl), build-cel - r2 (r2_celadon), build-cel - r2 (r2_clk)

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/587

@jennycao jennycao merged commit 6f92498 into projectceladon:master Jun 20, 2019
taowan1 pushed a commit that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants