This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
[DO-NOT-MERGE]support OVMF #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set KERNELFLINGER_AVB_CMDLINE := true to let kernelflinger process the command line option of vbmeta in UEFI based platform. Before enable this feature, please make sure the android kernel already support the AVB dm-verity, otherwise maybe cause kernel report error. Change-Id: I2038416613880b6bfb2d99c6e629d2c70b8d59ca Tracked-On: https://jira01.devtools.intel.com/browse/OAM-54527 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/613240
Change-Id: If50342ffe5128cf774467bdb19df8b8bc1a413d7 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-56891 Signed-off-by: Yang, Kai <kaix.yang@intel.com> Reviewed-on: https://android.intel.com:443/617805
Change-Id: I2806f8e3d8d45170babe513f831566539a9c2593 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-56888 Signed-off-by: dengx2x <xiangx.deng@intel.com> Reviewed-on: https://android.intel.com:443/617742
Change-Id: I82e333e007a8746e2e2a44df0328773f2800c69f Tracked-On: https://jira01.devtools.intel.com/browse/OAM-54855 Signed-off-by: jwu55 <ji.j.wu@intel.com> Reviewed-on: https://android.intel.com:443/614749
We use the edk2 library for creating and managing the TPM entities in kernelflinger. The necessary TPM functions are ported to kernelflinger/libedk2_tpm. The Tcg2 protocol headers are ported to libedk2_tpm/include. Github link : https://github.com/tianocore/edk2 Change-Id: I8ce9545e35cff9bc5a0d8b63ee49ea4aeb1b35cd Tracked-On: https://jira01.devtools.intel.com/browse/OAM-52486 Signed-off-by: adattatr <anisha.dattatraya.kulkarni@intel.com> Reviewed-on: https://android.intel.com:443/607205
If EFI_TCG2_PROTOCOL is supported by BIOS and if the device has Intel PTT (or fTPM), the SEED for Trusty is created by and stored in fTPM. With this change: - tpm2_security adds functions to write, read and create nv indexes. and generate seed for trusty. - fastboot oem fuse commands - at-perms-attr and vbmeta-verify-hash are added. - USE_TPM flag is added to enable the fuse commands - SOFT_FUSE flag is used in development phase so we can delete the NVRAM indexes. Change-Id: Ia9b714b084dc84a27c2860cb9e6f2e67c78bf0b4 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-52486 Signed-off-by: adattatr <anisha.dattatraya.kulkarni@intel.com> Reviewed-on: https://android.intel.com:443/607206
NVRAM indexes can be of type ORDINARY, COUNTER, or BITFIELD. The bootloader policy fuse is a bitfield nvindex with Bits signifying if provisioning is complete, if the device can be unlocked. Additionally with this change: - Add comments for the helper functions in Tpm2Help.c. - Add Tpm2NvSetBits and associated helper functions to manipulate the NVRAM bitfields. Tracked-On: https://jira01.devtools.intel.com/browse/OAM-52486 Change-Id: I41b3c4256c3517e9e77a5d3cd42df6402047bf7c Signed-off-by: adattatr <anisha.dattatraya.kulkarni@intel.com> Reviewed-on: https://android.intel.com:443/607207
Under 64 bit mode, linux kernel entry is 512 bytes after the start Change-Id: I5d8f188d7ead071af62528ec68cee5d9cb1aa7d0 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-57095 Signed-off-by: zhouji3x <jianfengx.zhou@intel.com> Reviewed-on: https://android.intel.com:443/618200
If trigger warning_disallowed, avb & slot-ab enable,will find some errors during osloader's 64bit complie progress. error: hardware/intel/kernelflinger/avb/libavb/uefi_avb_ops.c:85:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (num_bytes > (partition_size - offset_from_partition)) ^ cc1: all warnings being treated as errors Change-Id: I58511eaeb9c33053c50a44caec676fc9345938d4 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-57217 Signed-off-by: dengx2x <xiangx.deng@intel.com> Reviewed-on: https://android.intel.com:443/618741
Change-Id: I72d5608522ce7747506ad6a3bd2e97eb6b2687d1 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-57014 Signed-off-by: Yang, Kai <kaix.yang@intel.com> Reviewed-on: https://android.intel.com:443/617401
In order to launch trusty in osloader, the osloader has to pass different parameters to trusty for different platform, therefore has to design trusty launch depends on platform Change-Id: I8a00df99898388926c85dd8e81f3334b4ee63127 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-54691 Signed-off-by: kwen <kui.wen@intel.com> Reviewed-on: https://android.intel.com:443/612357
Change-Id: If956bd800bd7c0faf9e24b8e2a40742de3b42d35 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-58964 Signed-off-by: Yang, Kai <kaix.yang@intel.com> Reviewed-on: https://android.intel.com:443/620106
For avb_ab_flow, no need check the misc magic in the init. Change-Id: Ica5950eb65b130d2fff686c152c39eb676cca228 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-54486 Signed-off-by: biyilix <biyix.li@intel.com> Reviewed-on: https://android.intel.com:443/618764
Need revert this patch after UEFI enable avb flow boot. Change-Id: Ia2038974359e235dce360c4b6ba312abb923984d Tracked-On: https://jira01.devtools.intel.com/browse/OAM-54486 Signed-off-by: biyilix <biyix.li@intel.com> Reviewed-on: https://android.intel.com:443/619749
This reverts commit 390e316. Tracked-On: https://jira01.devtools.intel.com/browse/OAM-56901 Signed-off-by: biyilix <biyix.li@intel.com> Change-Id: Iac2594b02d0eea686c6eb78fc0d9ecd85492914d Reviewed-on: https://android.intel.com:443/617601
1 If fastboot host cmd send "flash bootloader" parameter, it auto append the slot suffix into bootloader name accroding to the DUT feedback, then send it for flash. 2 In UEFI platform, for bootloader&bootloder2 swap, can't mix with A|B. 3 Target is current slot bootloader when get hash value. Change-Id: Ibd0786de724c761502827b69793bd84380cc8a20 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-56901 Signed-off-by: biyilix <biyix.li@intel.com> Reviewed-on: https://android.intel.com:443/617436
Cur_suffix is NULL after gpt is updated. So when blank flash non-slot part, like bootloader in the UEFI platform, not check cur_suffix. When blank flash slot part, directly uses suffix in flash cmd. Change-Id: If6f58efb41ec96d91e27e0c81c476dd82d9ab38c Tracked-On: https://jira01.devtools.intel.com/browse/OAM-56901 Signed-off-by: biyilix <biyix.li@intel.com> Reviewed-on: https://android.intel.com:443/620318
Change-Id: I18a9579265828134e32cf031a1dec208c7374ba4 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-58988 Signed-off-by: Yang, Kai <kaix.yang@intel.com> Reviewed-on: https://android.intel.com:443/620297
Change-Id: I25c1a274487cd7b55026d06cc6fd541730d6b459 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-58976 Signed-off-by: biyilix <biyix.li@intel.com> Reviewed-on: https://android.intel.com:443/620571
1.Changing a 2-dimensional array as 1-dimensional array in security_abl.c and trusty_abl.c file. 2.Adding two judgements in kf4abl.c file. Change-Id: I372be27aed840eafa8475b4b7526582f50a7ebd8 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59116 Signed-off-by: yayongdx <yayongx.duan@intel.com> Reviewed-on: https://android.intel.com:443/620677
Also move the macro define of VBMETA_LABEL to vars.h. And enable get the hash of vbmeta partition when enable AVB. Change-Id: Ibdea0055f4957954eacd7c87d4bf49b04d613dc1 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-58981 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/620167
Enable qltipc in build. Set up qltipc connection after start tos. Change-Id: I87009f9c77e1ebcf46ee4b0d53075d00657019b0 Signed-off-by: swei22 <w.sheng@intel.com> Tracked-On: https://jira01.devtools.intel.com/browse/OAM-58556 Reviewed-on: https://android.intel.com/#/c/619628 Reviewed-on: https://android.intel.com:443/619628
Change-Id: I0bd01bb03664bf82fa1fff90a7adb1d6ab4973bb Signed-off-by: Zhang, Qi <qi1.zhang@intel.com> Tracked-On: https://jira01.devtools.intel.com/browse/OAM-58556 Reviewed-on: https://android.intel.com/#/c/619629 Reviewed-on: https://android.intel.com:443/619629
Kernelflinger does not have any assigned type_of_loader id. Per the Linux Kernel Documentation/x86/boot.txt it should set this field to 0xFF. Change-Id: I8fba670cb7ef7916b527fb14423d8e96fa914131 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119 Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Reviewed-on: https://android.intel.com:443/620108
According to the Linux Documentation/x86/boot.txt:
The memory for struct boot_params should be allocated and initialized
to all zero. Then the setup header from offset 0x01f1 of kernel image
on should be loaded into struct boot_params and examined. The end of
setup header can be calculated as follow:
0x0202 + byte value at offset 0x0201
Change-Id: I6483b6039c13d354e7a0a973519e3ec2412acd63
Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://android.intel.com:443/620109
With the recent support of the AllocatePages() service in efiwrapper,
there is no reason to keep a dedicated handover_kernel_abl() and a
dedicated setup_ramdisk_abl() function.
With this patch, the Kernel memory region and Ramdisk memory region
are dynamically allocated and do not rely on hardcoded memory
addresses. The Ramdisk memory is aligned on PAGE_SIZE which removes
the Linux Kernel complaints:
[<ffffffff813c2c35>] dump_stack+0x67/0x92
[<ffffffff8109a846>] warn_slowpath_common+0x86/0xc0
[<ffffffff8109a93a>] warn_slowpath_null+0x1a/0x20
[<ffffffff81047364>] free_init_pages+0x94/0xa0
[<ffffffff823bd030>] free_initrd_mem+0x2f/0x34
[<ffffffff823a8fa1>] free_initrd+0x20/0x38
[<ffffffff823a9787>] async_populate_rootfs+0x10d/0x13f
[<ffffffff810ba9fa>] async_run_entry_fn+0x4a/0x140
[<ffffffff810b296a>] process_one_work+0x14a/0x450
[<ffffffff810b2fa6>] worker_thread+0x66/0x450
[<ffffffff810b2f40>] ? rescuer_thread+0x2d0/0x2d0
[<ffffffff810b802d>] kthread+0xfd/0x120
[<ffffffff810b7f30>] ? kthread_create_on_node+0x190/0x190
[<ffffffff81a019ef>] ret_from_fork+0x3f/0x70
[<ffffffff810b7f30>] ? kthread_create_on_node+0x190/0x190
Change-Id: I9ffdd654f524c5074bcbe80b18c81abad6735b8e
Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://android.intel.com:443/620110
Change-Id: I27c07005b5a95198d19a8fbe06824a493d70ad0f Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119 Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Reviewed-on: https://android.intel.com:443/620111
This patch adds the is_UEFI() function which returns TRUE when Kernelflinger run on a UEFI() BIOS or FALSE otherwise. The detection of a non UEFI system relies on the System Table Firmware Vendor field which set a known value: L"Intel-Efiwrapper". Change-Id: Iab5e88dc498018bf539d6717552bf72cb53887c7 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119 Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Reviewed-on: https://android.intel.com:443/620112
The setup_memory_map() function is called by both UEFI and non UEFI handover functions. On non UEFI system, the System Table is powered by a emulation library that is lost once Kernelflinger handover to the Linux Kernel. The patch makes sure setup_memory_map() does not populate the boot_params efi_info structure if it is running on a non UEFI system. Change-Id: I843a44ffa7273775bb559b25a3f8dbaaa2bf0245 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119 Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Reviewed-on: https://android.intel.com:443/620114
android_image_start_buffer_abl() is duplication of android_image_start_buffer(). This patch converge the use of android_image_start_buffer(). Change-Id: I91e81fdc8c45f7a62a14dce95051333a7614e8a5 Tracked-On: https://jira01.devtools.intel.com/browse/OAM-59119 Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Reviewed-on: https://android.intel.com:443/620113
Do not expand tab now. Change-Id: Ia14132f7f9416ab19b5a166b288f7b250235dc06 Tracked-On: https://jira.devtools.intel.com/browse/OAM-75981 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/659430
Change-Id: Ifb6d42fb4b65d8109feb796c4d7772ced17eee92 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76189 Signed-off-by: Xihua Chen <xihua.chen@intel.com> Reviewed-on: https://android.intel.com:443/660192
Change-Id: I6cdc010e40ccac532093f405bc710d5f9fa4d3ef Tracked-On: https://jira01.devtools.intel.com/browse/OAM-76248 Signed-off-by: Zhang, Xuepeng <xuepeng.zhang@intel.com> Reviewed-on: https://android.intel.com:443/661583
On x86, stack protector save canary value(4 bytes) to GS:0x14. GS is set to the same selector as DS, base address of the selector is 0, limit is 4G. android_clear_memory clear page 0, so stack canary need be saved before clear and be restored after clear. referrences kernel/4.14/arch/x86/include/asm/stackprotector.h Change-Id: I1804427d0701085bd5024c39e3ffaab8350124b7 Tracked-On: https://jira.devtools.intel.com/browse/OAM-75572 Signed-off-by: keyuliux <keyux.liu@intel.com> Reviewed-on: https://android.intel.com/660286 Reviewed-on: https://android.intel.com:443/660286
we perform a "safe flash procedure" for esp partition: 1. write data to the BOOTLOADER_TMP_PART partition 2. perform sanity check on BOOTLOADER_TMP_PART partition files 3. swap BOOTLOADER_PART and BOOTLOADER_TMP_PART partition 4. erase BOOTLOADER_TMP_PART partition 5. install the load options into the Boot Manager Change-Id: I402917c9802945e947f126fc7209106794be4371 Tracked-On: https://jira.devtools.intel.com/browse/OAM-73951 Signed-off-by: Heng Luo <heng.luo@intel.com> Reviewed-on: https://android.intel.com:443/661700
For non UEFI platform, perform "default flash procedure". For UEFI platform, perform a "safe flash procedure" if bootloader2 partition exists; otherwise, return EFI_UNSUPPORTED. Change-Id: I731a2e63362386e5ae417ddb7a3fd483a4b65159 Tracked-On: https://jira.devtools.intel.com/browse/OAM-73952 Signed-off-by: Heng Luo <heng.luo@intel.com> Reviewed-on: https://android.intel.com:443/661701
Change-Id: I407d0a9a7db199c2f8204a5dd7abacca1e0aafcd Tracked-On: https://jira01.devtools.intel.com/browse/OAM-52565 Signed-off-by: JianFeng,Zhou <jianfeng.zhou@intel.com> Reviewed-on: https://android.intel.com:443/657011
Access SATA by PassThru, if transfer length is larger than the ATA controller can handle, EFI_BAD_BUFFER_SIZE is returned and The number of bytes that could be transferred is returned in InTransferLength. But it is not always true, espacially in AHCI mode, IntransferLength is not updated. Change-Id: I32b79685cad91bac265e5991caa623f14d98774a Tracked-On: https://jira.devtools.intel.com/browse/OAM-76102 Signed-off-by: Meng Xianglin <xianglinx.meng@intel.com> Reviewed-on: https://android.intel.com:443/661761
Change-Id: Id732b7b0f81bc5c03fb4f65f91f8eabadefe69dc Tracked-On: https://jira.devtools.intel.com/browse/OAM-76476 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/662173
Move the code to libkernelflinger, so other program can call this function. Also change the logical of checking upgrade file. Also add the function StrcaseCmp. Change-Id: I7311ab9a2a8a97e6ada2fcac6b0c64a8418b04aa Tracked-On: https://jira.devtools.intel.com/browse/OAM-76158 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/660191
The buffer of output a row is 128 Bytes at log.c , but the length of string may be more than 128B, so that the buffer was setted 512 Bytes. Change-Id: I55e52bbb2845e8787785652159093f2acceb2537 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76295 Signed-off-by: Yanhongx.Zhou <yanhongx.zhou@intel.com> Reviewed-on: https://android.intel.com:443/662107
Do null check for pointer 'label' before dereferenced. Change-Id: I967957643855d40f10b83a8abe6b3ef8b5556cd0 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76475 Signed-off-by: sunxunou <xunoux.sun@intel.com> Reviewed-on: https://android.intel.com:443/574932
Current UFS user LUN is hard code as LUN0. must change code and rebuild bootloader if UFS layout changed. we remove this restriction at here. Change-Id: I277e917fc5380b3e2e945564fdd7612e9ea34711 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76642 Signed-off-by: Tang, Haoyu <haoyu.tang@intel.com> Reviewed-on: https://android.intel.com:443/655994 (cherry picked from commit 0e0882339507758387d7a85824b5e7ebadd4bd2a) Reviewed-on: https://android.intel.com:443/662683
1. Do null check for pointer 'boot_device' before dereferenced. 2. Initialize 'already_read' before be used function. Change-Id: I573442ef64a499dbec3f366a904342f0574b65f2 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76884 Signed-off-by: sunxunou <xunoux.sun@intel.com> Reviewed-on: https://android.intel.com:443/663472
"fastboot boot boot.img" should boot the whole android system up to UI. When boot.img is download into memeory, it should be treated as "is_bootimg_target" and allow the boot procedure to assemble enough kernel parameters, it's boot target should be NORMAL_BOOT Change-Id: Idd712b88cabd7ac11765a5304cf2d90bdc1297a4 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76556 Signed-off-by: Meng Xianglin <xianglinx.meng@intel.com> Reviewed-on: https://android.intel.com:443/663618
call avbtool from a fixed directory, resolve fb4abl.abl rebuilt in every build. Change-Id: I469df322b4199dc4b457dce529c315ff65408b4b Tracked-On: https://jira.devtools.intel.com/browse/OAM-76304 Signed-off-by: keyuliux <keyux.liu@intel.com> Reviewed-on: https://android.intel.com:443/663467
end_user is set to TRUE if fails to read EOM and SB. This is for ACRN AaaG to be regarded as an end user image to retrieve AttKB. Change-Id: Icecf8b3243e29c46180f68183ec55e984ed87bb0 Tracked-On: https://jira.devtools.intel.com/browse/OAM-76936 Signed-off-by: Zhang, Xuepeng <xuepeng.zhang@intel.com> Reviewed-on: https://android.intel.com:443/663830
After call get_argv(), the command line option will not changed. Change-Id: I582470bac9ff3627765ea1fc727b148f89b7b781 Tracked-On: https://jira.devtools.intel.com/browse/OAM-77006 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/664066
The build out "fastboot" is positioned as basic flash tool only. Thus, limited fastboot commands are supported: fastboot flash <partition> <filename> //flash gpt or flash some data to a disk partition or some special data. fastboot erase <partition> //erase a partition. fastboot gatvar <var_name>|all //get a var value or all vars value. fastboot reboot //Reboot the device. fastboot reboot-bootloader //Reboot the device to fastboot mode. Change-Id: I298f0906db5ee2557526fc1f3f93d9c3731608c1 Tracked-On: https://jira.devtools.intel.com/browse/OAM-70124 Signed-off-by: Meng Xianglin <xianglinx.meng@intel.com> Reviewed-on: https://android.intel.com:443/663966
…wer off delete LOADER_ENTRY_ONESHOT efi variable after detect oneshot. Change-Id: I216aaa7ab1ea901263a6b8885784f46adcb3ab95 Tracked-On: https://jira.devtools.intel.com/browse/OAM-77017 Signed-off-by: keyuliux <keyux.liu@intel.com> Reviewed-on: https://android.intel.com:443/664071
It is used for support bootloader A/B slot, bootloader_a/_b. In libkernelflinger, also add the functions to set and get the loaded slot and the error code of load slot failed. Change-Id: Iff3a9a7718d066e2e12fd54bd58963780656743c Tracked-On: https://jira.devtools.intel.com/browse/OAM-73949 Signed-off-by: Ming Tan <ming.tan@intel.com> Reviewed-on: https://android.intel.com:443/663941
The purpose of this patch is try to reduce the USE_AVB macro definitions in kernelflinger to make it more easy for maintenance. The major change is to split the android.c and security.c into multiple files, move the verified boot related functions into android_vb1.c and android_vb2.c, vb1 suffix means verified boot 1.0 specific code, vb2 suffix means verified boot 2.0 specific code, same for security.c. Change-Id: I6c1620e9a2d34cb783b8c17ef1d6bc36a87b5a93 Tracked-On: https://jira.devtools.intel.com/browse/OAM-75485 Signed-off-by: Genshen, Li <genshen.li@intel.com> Reviewed-on: https://android.intel.com:443/664254
1. Null check for pointer 'g_disk_device' before dereferenced. 2. Check array buf index range. Change-Id: I14b995d9c5219a384d05c7040143cb0f5910f0dd Tracked-On: https://jira.devtools.intel.com/browse/OAM-79045 Signed-off-by: sunxunou <xunoux.sun@intel.com> Reviewed-on: https://android.intel.com:443/665392
1. Disable the slot if kfld is failed to load it. 2. Get the slot that kfld uses from efi variable, if kfld and kernelflinger use different slot, trigger reboot. Change-Id: I778c58473e56f4298becaa3a02565f8b521ecef9 Tracked-On: https://jira.devtools.intel.com/browse/OAM-73953 Signed-off-by: Heng Luo <heng.luo@intel.com> Reviewed-on: https://android.intel.com:443/664697
Use simulate RPMB if physical RPMB not found.But kernelflinger failed to use simulate RPMB if physical RPMB is not found. Change-Id: I9f0a0b6f8c9fe10e0807ffdb8e17529e35267e96 Tracked-On: https://jira.devtools.intel.com/browse/OAM-80064 Signed-off-by: Yanhongx.Zhou <yanhongx.zhou@intel.com> Reviewed-on: https://android.intel.com:443/667911
Initialize 'file' and 'tree1d' array before dereferenced. Change-Id: Iee390d7f58478a7c1522e5cccc4ab5a59e187923 Tracked-On: https://jira.devtools.intel.com/browse/OAM-80261 Signed-off-by: sunxunou <xunoux.sun@intel.com> Reviewed-on: https://android.intel.com:443/668922
Commit 52965e5 broke the transport layer fallback mecanism. The usb_start should run EFI_UNSUPPORTED if the no USB protocol are support (and not EFI_NOT_FOUND). The transport_start() function depend on this particular error to decide to fallback on the next available protocol implementation which is currently TCP if the UEFI BIOS support this protocol. Change-Id: I118197c8da912abe79371c45b087d8d4fb13b756 Tracked-On: https://jira.devtools.intel.com/browse/OAM-80319 Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> Reviewed-on: https://android.intel.com:443/669159
Change-Id: I25a15a1dd51187c0dce172b264d3da8c24b2717c Tracked-On: https://jira.devtools.intel.com/browse/OAM-82661 Signed-off-by: sunxunou <xunoux.sun@intel.com> Reviewed-on: https://android.intel.com:443/671237
Signed-off-by: Qi Yadong <yadong.qi@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qi Yadong yadong.qi@intel.com