Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the black screen was observed in the CarSettings #182

Merged
merged 1 commit into from Jan 28, 2019
Merged

Fix the black screen was observed in the CarSettings #182

merged 1 commit into from Jan 28, 2019

Conversation

arvinwax
Copy link
Contributor

The black screen observed due to the mGridAdapter data
was cleared on the onStop status. Adding the mGridAdapter
data in the onStart status to recovery the data.

Test:

  1. Set a pattern/pin lock as an owner
  2. Click on the notification symbol and click "add new user"
  3. Once UI is at new user screen > switch back to owner
  4. When prompted to enter pattern/pin > click on "cancel"
  5. Click on owner from "lock screen" > enter pattern > owner UI comes up
  6. Click on car settings > observe

Tracked-On: https://jira.devtools.intel.com/browse/OAM-75447
Signed-off-by: Wang, ArvinX arvinx.wang@intel.com

The black screen observed due to the mGridAdapter data
was cleared on the onStop status. Adding the mGridAdapter
data in the onStart status to recovery the data.

Test:
1) Set a pattern/pin lock as an owner
2) Click on the notification symbol and click "add new user"
3) Once UI is at new user screen > switch back to owner
4) When prompted to enter pattern/pin > click on "cancel"
5) Click on owner from "lock screen" > enter pattern > owner UI comes up
6) Click on car settings > observe

Tracked-On: https://jira.devtools.intel.com/browse/OAM-75447
Signed-off-by: Wang, ArvinX <arvinx.wang@intel.com>
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autobuild started from pull-request-changes on this PR.

Cactus automatically verified this PR.

For more information, see: /absp/builders/celadon-autobuild/builds/222

Copy link
Contributor Author

@arvinwax arvinwax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongcheng-xie @walterx-yan ,
Please help to review, thanks.

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'preintegration' builder

More details, logs, and binaries: /absp/builders/celadon-preintegration/builds/171

Done by "Zhang, JohnX" johnx.zhang@intel.com

Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR integrated into 'premerge' builder

More details, logs, and binaries: /absp/builders/celadon-premerge/builds/80

Done by "Zhang, JohnX" johnx.zhang@intel.com

@sysopenci sysopenci merged commit 5969694 into projectceladon:master Jan 28, 2019
Copy link

@sysopenci sysopenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cactus finished building and testing your PR

It was requested for merge by "Zhang, JohnX" johnx.zhang@intel.com

so we merge it. Thanks for your contribution.

more details, logs, and binaries: /absp/builders/celadon-mergerequest/builds/510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants