-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix demo_WheeledGeneric when Irrlicht is not available #197
Fix demo_WheeledGeneric when Irrlicht is not available #197
Conversation
12f468b
to
0018a83
Compare
0018a83
to
489fe65
Compare
I'm not sure I understand the point of this change. This demo is not built unless the Chrono::Irrlicht module is enabled (see its CMakeLists.txt). The "generic" vehicle is used mostly as a sandbox for developing new vehicle features and general testing and so we do want this demo to always have visualization enabled. |
When I saw the issue that e4410d7 fixes, I did a look-around to ensure it did not affect any other examples. In doing so, I noticed the following have the same spirit of being able to build without Irrlicht:
You raise an interesting point that these are not built when |
You're right. There are some inconsistencies here.
Having said that, it's great you want to help with a bit of house cleaning.
|
Good point on the visualization assets; that change is wrong, will revert. Thank you for the guidance! |
@rserban I'm happy with these changes, can you take another look? I tested by building with and without |
Looks good to me. But please squash all these commits into a single one. |
b170289
to
587887a
Compare
squashed |
There was a reference to Irrlicht that was not
#ifdef
'd. I also#ifdef
d some of the visualization configuration to better show what is not needed when visualization is unused.