Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with GCC on FreeBSD #146

Closed
wants to merge 2 commits into from
Closed

Fix build with GCC on FreeBSD #146

wants to merge 2 commits into from

Conversation

pkubaj
Copy link

@pkubaj pkubaj commented Mar 28, 2019

This is needed because some platforms still use GCC (like all powerpc platforms).

This is needed because some platforms still use GCC (like all powerpc platforms).
@rserban
Copy link
Member

rserban commented Mar 28, 2019

By the way, I don't think this is a GCC issue.
I suspect this is because of PATH_MAX?
While, in general, we prefer not to modify code in the "chrono_thirdparty" directory, I'm fine accepting this change. However, before that, could you please check if the following will work:

#ifdef __FreeBSD__
# include <limits.h>
#endif

@pkubaj
Copy link
Author

pkubaj commented Mar 28, 2019

Yes, this also works.

@rserban
Copy link
Member

rserban commented Mar 28, 2019

Could you then amend your PR? Or else I can push this fix.
Thanks

@pkubaj
Copy link
Author

pkubaj commented Apr 3, 2019

Changed.

@rserban
Copy link
Member

rserban commented Apr 3, 2019

I thought it's not worth pulling 2 commits for a single-line change, so I made and pushed this change directly. Please let me know if this works for you.

@rserban rserban closed this Apr 3, 2019
@pkubaj
Copy link
Author

pkubaj commented Apr 4, 2019

Yes, it works, thanks.

@pkubaj pkubaj deleted the patch-1 branch April 4, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants