Changes to ChCollisionModel method prototypes #8
Conversation
Added a new ChMatrix33 constructor which builds a diagonal matrix with same elements on the diagonal (useful to construct an identity 3x3 matrix). Added two utility functions which test if a 3x3 matrix is the identity matrix and if a vector is the null vector, respectively.
More such changes should be done. These are the ones required for the changes to the ChCollisionModel::Add***() function prototypes.
Modified the prototypes of all functions used to specify collision geometry so that they take const refs to the position and orientation of the contact shapes (instead of pointers to a ChVector and ChMatrix33, respectively). This cleans up the code and addresses compilation warnings regarding 'taking address of temporary' (gcc) or 'class rvalue used as lvalue' (cl).
Pass position and orientation matrix for contact shapes as const refs, not pointers.
Move defintions of static functions from the header file to the source file so that these functions are not multiply-defined.
|
hi Radu, alessandro Il 16/11/2013 18:47, Radu Serban ha scritto:
|
|
Sounds good Alessandro. |
By default, CMake links executables with full RPATH only in the build tree and clears the RPATH before installing targets. This means that, by default, installed executables will not find the shared libraries (unless these are installed in a default location, such as /usr/local/lib). With this change (lifted directly from the CMake wiki), executables are relinked with the install RPATH. This allows running the installed executables regardless of the installation location and without having to change LD_LIBRARY_PATH.
|
Hi Radu, I applied your pull request to the chrono origin, but only for the develop branch (from this moment, I'll keep most modifications into the develop branch, and we'll merge develop into master only for main releases). |
|
Btw, about the ChCollisionModel changes: you are right about the arguments passed to the functions, that took temporary addresses. I always postponed a change to this class because I'd also like to have it more coherent with the way that cylinder, boxes etc. geometries are created in the ChAsset subclasses (those used for visualization). |
cleaned up CMakeLists for Windows MSVC builds
* Removing linking libiomp5.lib for vs 2019 deployment * Implemented build_pychrono.bat code in gitlab-ci.yml * Fixed .gitlab-ci.yml for windows deployment * Fixing windows deployment CI script * Made changes to gitlab-ci.yml file * Edited .gitlab-ci.yml to fix vs2019 deploy script * Attempting conda build with conda-forge channel for vs2019 deploy * Changed bld.bat to fix environment variables * Edited meta.yaml for vs2019 deployment * Attempting to run vs2019 deployment with correct vs compiler version * Attempting to run vs2019 deployment with correct vs compiler version * Attempt to use vs2019 for windows:vs2019 deployment * Attempt to fix vs2019 #2 * Attempt to fix vs2019 #3 * Attempt to fix vs2019 #3 * Attempt to fix vs2019 #4 * Attempt to fix vs2019 #4 * Attempt to fix vs2019 #5 * Change windows conda compiler * Attempt to fix vs2019 #6 * Attempt to fix vs2019 #7 * Attempt to fix vs2019 #8 * Attempt to fix vs2019 #9 * Attempt to fix vs2019 #10 * Attempt to fix vs2019 #11 * Attempt to fix vs2019 #12 * Attempt to fix vs2019 #12 * Attempting vs2019 deployment for windows without irrlcith * Attempt to fix vs2019 #13 * Attempt to fix vs2019 #14 * Attempting to get vs2019 deployment to pick correct location for Irrlicht * Revert "Attempting to get vs2019 deployment to pick correct location for Irrlicht" This reverts commit bea088d. * Attempt to fix vs2019 #15
I have made some fixes to the Add***() virtual methods in ChCollisionModel to pass the position vector and rotation matrix through const refs instead of pointers.
This simplifies and cleans up the code and removes the reliance on nonstandard compiler extensions (i.e., it fixes the 'taking address of temporary' linker warnings with gcc or warning C4238 with VS: 'class rvalue used as lvalue').
I have tested this both on Windows (VS2010) and Linux (gcc). Note that some updates would have to be made to the derived class ChModelSphereSet when chrono-mpi is reinstated.