Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Flaky CI Tests #251

Closed
danehans opened this issue Mar 9, 2021 · 4 comments · Fixed by #313
Closed

Flaky CI Tests #251

danehans opened this issue Mar 9, 2021 · 4 comments · Fixed by #313
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
1.15.0

Comments

@danehans
Copy link
Contributor

danehans commented Mar 9, 2021

CI jobs are intermittently failing. I'm unable to reproduce the flake, but I believe it's related to updating a Contour from defaults to Gateway-enabled in test_suite.go. This issue may be resolved by #250. In the meantime, I suggest disabling this portion of the test since the e2e tests cover Gateway support.

xref: #249
@danehans danehans added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2021
@danehans
Copy link
Contributor Author

danehans commented Mar 9, 2021

If converting an existing Contour to Gateway-API enabled is flaky, maybe doc the API field as immutable.

@danehans danehans mentioned this issue Mar 9, 2021
Closed
@danehans danehans added this to Unprioritized in Contour Project Board via automation Mar 9, 2021
@danehans danehans added this to the 1.14.0 milestone Mar 9, 2021
@danehans danehans moved this from Unprioritized to 1.14 release in Contour Project Board Mar 9, 2021
@danehans
Copy link
Contributor Author

danehans commented Mar 9, 2021

xref: #218 could also be the issue.

@danehans
Copy link
Contributor Author

danehans commented Mar 29, 2021 •
edited
Loading

Moving to 1.15.0 while the community achieves a consensus on the Gateway API implementation plan.

@danehans danehans moved this from 1.14 release to 1.15 release in Contour Project Board Mar 29, 2021
@danehans danehans modified the milestones: 1.14.0, 1.15.0 Mar 29, 2021
@nak3 nak3 mentioned this issue Apr 9, 2021
Closed
@skriss
Copy link
Member

skriss commented Apr 19, 2021

Still seeing this in suite_test.go, e.g. https://github.com/projectcontour/contour-operator/runs/2381643663?check_suite_focus=true.

I'll look into this some more and see if I can figure out a fix. May be a matter of adding some retries around updates, or switching to using Patch instead.

skriss added a commit to skriss/contour-operator that referenced this issue Apr 19, 2021
@skriss
internal/operator: tests: wrap updates in Eventually
300ca9b 
In suite_test.go, wraps Update(...) calls in Eventually(...)
to mitigate concurrent modification issues causing test flakes.

Closes projectcontour#251.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Apr 19, 2021
Merged
danehans pushed a commit that referenced this issue Apr 19, 2021
@skriss
internal/operator: tests: wrap updates in Eventually (#313)
19d802f 
In suite_test.go, wraps Update(...) calls in Eventually(...)
to mitigate concurrent modification issues causing test flakes.

Closes #251.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
1.15.0
2 participants
@danehans @skriss