This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Includes Contour Namespace in Cluster RBAC Resources #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehans
requested review from
skriss and
sunjayBhatia
and removed request for
a team
skriss
changed the title
skriss
reviewed
Mar 29, 2021
danehans
force-pushed
the
crb_fix_option_2
branch
from
7a0cd91
to
66bbde6
Compare
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
danehans
force-pushed
the
crb_fix_option_2
branch
from
66bbde6
to
38fd172
Compare
skriss
reviewed
Mar 30, 2021
youngnick
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OtherContoursExistInSpecNs(): Ensures the contour from the list is not the same as thecontourparameter before comparingspec.namespace.name. Fixes #281Manages cluster-scoped RBAC resources on a per-Contour basis. Adds an e2e to test the multi-Contour use case. Fixes #280
Signed-off-by: Daneyon Hansen daneyonhansen@gmail.com