This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Create envoy service with ClusterIPService type and gatewayClassRef #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nak3
requested review from
skriss and
sunjayBhatia
and removed request for
a team
|
/cc @danehans |
sunjayBhatia
reviewed
Apr 2, 2021
danehans
reviewed
Apr 5, 2021
operator does not create envoy service when envoy is ClusterIPService type and gatewayClassRef. This patch fixes it. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
- make sure envoy svc deletion - Polling instead of sleep until access works. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
skriss
approved these changes
Apr 8, 2021
|
@danehans or @sunjayBhatia this is ready for final review + merge. |
sunjayBhatia
approved these changes
Apr 12, 2021
stevesloka
pushed a commit
to stevesloka/contour-operator
that referenced
this pull request
Apr 16, 2021
…rojectcontour#293) operator does not create envoy service when envoy is ClusterIPService type and gatewayClassRef. This patch fixes it. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator does not create envoy service when envoy
is ClusterIPService type and gatewayClassRef.
This patch fixes it.
Fix #291
Signed-off-by: Kenjiro Nakayama nakayamakenjiro@gmail.com