This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
internal/objects/service: refactor test #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors to check each Envoy service for an exact set of annotation keys, rather than checking for the existence and non-existence of a subset of annotations. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
stevesloka and
sunjayBhatia
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 58.18% 58.18%
=======================================
Files 19 19
Lines 1801 1801
=======================================
Hits 1048 1048
Misses 727 727
Partials 26 26 Continue to review full report at Codecov.
|
sunjayBhatia
approved these changes
May 28, 2021
danehans
approved these changes
Jun 2, 2021
|
Thanks for the PR @skriss. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors to check each Envoy service for an exact set
of annotation keys, rather than checking for the existence
and non-existence of a subset of annotations.
Signed-off-by: Steve Kriss krisss@vmware.com