Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Add example contour deployment with internal-elb #390

Merged
merged 1 commit into from Jun 24, 2021

Conversation

erismaster
Copy link
Contributor

Adds an example contour custom resoruce object that would provision with
an internal-facing load balancer.

@erismaster erismaster requested a review from a team as a code owner June 22, 2021 19:17
@erismaster erismaster requested review from stevesloka and danehans and removed request for a team June 22, 2021 19:17
Adds an example contour custom resoruce object that would provision with
an internal-facing load balancer.

Signed-off-by: Derrik Campau <dcampau@vmware.com>
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #390 (42eb706) into main (892c8c1) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 42eb706 differs from pull request most recent head 7599027. Consider uploading reports for the commit 7599027 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   59.58%   59.48%   -0.11%     
==========================================
  Files          19       19              
  Lines        1888     1888              
==========================================
- Hits         1125     1123       -2     
- Misses        737      738       +1     
- Partials       26       27       +1     
Impacted Files Coverage Δ
pkg/validation/validation.go 81.20% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892c8c1...7599027. Read the comment docs.

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erismaster!

@skriss skriss merged commit 3da16cc into projectcontour:main Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants