bug: does cmd/contour have to call flag.Parse unconditionally

[davecheney]

ERROR: logging before flag.Parse: W1218 11:31:33.776933   73199 reflector.go:341] github.com/heptio/contour/internal/k8s/watcher.go:61: watch of *v1.Endpoints ended with: too old resource version: 8605078 (8606302)

cmd/contour uses kingpin, not flag, but I suspect the glog infection via client-go requires flag.Parse to be called unconditionally.

[willmadison]

I'll take a look at this. Is the glog implicit dependency confirmed or simply suspected at this moment?

[davecheney]

We get it for free with client-go.

…

On Tue, Dec 19, 2017 at 10:57 AM, Will Madison ***@***.***> wrote: I'll take a look at this. Is the glog implicit dependency confirmed or simply suspected at this moment? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA_wmk0CqcgaSundAYmj8BhRLdIxnks5tBvwCgaJpZM4RE3BT> .

[willmadison]

Kewl I'll investigate further. I'd like to add an appropriate test for this bug but it sounds like it's as simple as adding an innocuous call to flag.Parse() but I'll look into it

[davecheney]

I'm fine with not having a test for this, a sufficiently scarey comment in cmd/contour/contour.go will do // we need this because (long rant about how glog is terrible) func init() { flag.Parse() }

…

On Tue, Dec 19, 2017 at 11:07 AM, Will Madison ***@***.***> wrote: Kewl I'll investigate further. I'd like to add an appropriate test for this bug but it sounds like it's as simple as adding an innocuous call to flag.Parse() but I'll look into it — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcA-QtmsHb8QOYkolDeUhMLHakk--cks5tBv5NgaJpZM4RE3BT> .

[willmadison]

Fair enough. PR coming in just a sec...