Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility to split a Kubernetes object name into a FullName #2518

Closed
jpeach opened this issue May 12, 2020 · 1 comment
Closed

Add utility to split a Kubernetes object name into a FullName #2518

jpeach opened this issue May 12, 2020 · 1 comment
Labels
area/testing Issues or PRs related to tests or testing tools. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@jpeach
Copy link
Contributor

jpeach commented May 12, 2020

There are currently 2 places in the code that split a Kubernetes namespace/name string; featuretests.meta() and dag.splitSecret(). We can consolidate these into k8s.FullName affordances so that we can use FullName in more places. Also, converting a k8s.FullName into ObjectMeta is useful.
@jpeach jpeach added area/testing Issues or PRs related to tests or testing tools. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 12, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Jul 13, 2020

Not to be fixed. featuretests.meta() is gone; there's not much here to clean up.

@jpeach jpeach closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to tests or testing tools. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpeach