Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to v1 ClusterRoleBinding for deployment RBAC #2991

Closed
jpeach opened this issue Oct 6, 2020 · 3 comments · Fixed by #3015
Closed

Move to v1 ClusterRoleBinding for deployment RBAC #2991

jpeach opened this issue Oct 6, 2020 · 3 comments · Fixed by #3015
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jpeach
Copy link
Contributor

jpeach commented Oct 6, 2020

Please describe the problem you have

rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding

customresourcedefinition.apiextensions.k8s.io/extensionservices.projectcontour.io created
customresourcedefinition.apiextensions.k8s.io/httpproxies.projectcontour.io created
customresourcedefinition.apiextensions.k8s.io/tlscertificatedelegations.projectcontour.io created
Warning: rbac.authorization.k8s.io/v1beta1 ClusterRoleBinding is deprecated in v1.17+, unavailable in v1.22+; use rbac.authorization.k8s.io/v1 ClusterRoleBinding
clusterrolebinding.rbac.authorization.k8s.io/contour created
@jpeach jpeach added kind/feature Categorizes issue or PR as related to a new feature. area/deployment Issues or PRs related to deployment tooling or infrastructure. labels Oct 6, 2020
@jpeach jpeach added this to Unprioritized in Contour Project Board via automation Oct 6, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Oct 6, 2020

xref projectcontour/contour-operator#21 creates v1 ClusterRoleBindings

@narahari92
Copy link
Contributor

@jpeach I can pick this up if you aren't working on it already. Please let me know.

@jpeach
Copy link
Contributor Author

jpeach commented Oct 8, 2020 •
edited by skriss

@jpeach I can pick this up if you aren't working on it already. Please let me know.

That sounds great! Just note that the minimum kubernetes version we support is 1.6 1.16 so check that the APIs are present there :)

narahari92 added a commit to narahari92/contour that referenced this issue Oct 9, 2020
@narahari92
deployment: Update rbac versions from v1beta1 to v1
48e3a0d 
Update the apiVersions of resources in rbac group such as  ClusterRoleBinding, Role etc. to
v1 version from  v1beta1 as it's deprecated since kubernetes 1.17 version and will be removed
in 1.22 version.

Fixes projectcontour#2991

Signed-off-by: hnarahari <hnarahari@vmware.com>
narahari92 added a commit to narahari92/contour that referenced this issue Oct 9, 2020
@narahari92
deployment: Update rbac versions from v1beta1 to v1
f1cbf6c 
Update the apiVersions of resources in rbac group such as  ClusterRoleBinding, Role etc. to
v1 version from  v1beta1 as it's deprecated since kubernetes 1.17 version and will be removed
in 1.22 version.

Fixes projectcontour#2991

Signed-off-by: hnarahari <hnarahari@vmware.com>
@narahari92 narahari92 mentioned this issue Oct 9, 2020
Merged
@skriss skriss moved this from Unprioritized to In progress in Contour Project Board Oct 9, 2020
Contour Project Board automation moved this from In progress to 1.10 Release Oct 9, 2020
stevesloka pushed a commit that referenced this issue Oct 9, 2020
@narahari92
deployment: Update rbac versions from v1beta1 to v1 (#3015)
1e99a20 
Update the apiVersions of resources in rbac group such as  ClusterRoleBinding, Role etc. to
v1 version from  v1beta1 as it's deprecated since kubernetes 1.17 version and will be removed
in 1.22 version.

Fixes #2991

Signed-off-by: hnarahari <hnarahari@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/deployment Issues or PRs related to deployment tooling or infrastructure. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deployment: Update rbac versions from v1beta1 to v1 narahari92/contour
2 participants
@jpeach @narahari92