Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace use of deprecated field envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format #3210

Closed
skriss opened this issue Dec 16, 2020 · 1 comment · Fixed by #3330
Closed

replace use of deprecated field envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format #3210

skriss opened this issue Dec 16, 2020 · 1 comment · Fixed by #3330
Assignees
@abhide
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
1.13.0

Comments

@skriss
Copy link
Member

skriss commented Dec 16, 2020

Using Envoy 1.16.1, the following warning occurs on startup:

[2020-12-16 19:56:32.696][1][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.extensions.access_loggers.file.v3.FileAccessLog Using deprecated option 'envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format' from file file.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

ref. https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/access_loggers/file/v3/file.proto#extensions-access-loggers-file-v3-fileaccesslog
@skriss skriss added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Dec 16, 2020
@abhide
Copy link
Member

abhide commented Feb 5, 2021

I would like to work on this issue.
If you don't mind, can either of @stevesloka or @skriss assign this issue to me?

@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Feb 5, 2021
@skriss skriss added this to Unprioritized in Contour Project Board via automation Feb 5, 2021
@skriss skriss moved this from Unprioritized to In progress in Contour Project Board Feb 5, 2021
abhide added a commit to abhide/contour that referenced this issue Feb 6, 2021
@abhide
Update usage of deprecated field FileAccessLog.json_format
0772a5f 
Replace usage of deprecated field
envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format
with
envoy.extensions.access_loggers.file.v3.FileAccessLog.log_format

Fixes: projectcontour#3210
Signed-off-by: Amey Bhide <amey15@gmail.com>
@abhide abhide mentioned this issue Feb 6, 2021
Merged
abhide added a commit to abhide/contour that referenced this issue Feb 8, 2021
@abhide
Merge branch 'main' into projectcontourGH-3210
092746d
skriss added a commit to abhide/contour that referenced this issue Feb 8, 2021
@skriss
Merge branch 'main' into projectcontourGH-3210
0c49545
Contour Project Board automation moved this from In progress to 1.13 Release Feb 8, 2021
skriss pushed a commit that referenced this issue Feb 8, 2021
@abhide
Update usage of deprecated field FileAccessLog.json_format (#3330)
b803b04 
Replace usage of deprecated field
envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format
with
envoy.extensions.access_loggers.file.v3.FileAccessLog.log_format

Fixes: #3210
Signed-off-by: Amey Bhide <amey15@gmail.com>
@skriss skriss added this to the 1.13.0 milestone Feb 8, 2021
iyacontrol pushed a commit to iyacontrol/contour that referenced this issue Feb 18, 2021
@abhide @iyacontrol
Update usage of deprecated field FileAccessLog.json_format (projectco…
e1c38c0 
…ntour#3330)

Replace usage of deprecated field
envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format
with
envoy.extensions.access_loggers.file.v3.FileAccessLog.log_format

Fixes: projectcontour#3210
Signed-off-by: Amey Bhide <amey15@gmail.com>
Signed-off-by: iyacontrol <gaohj2015@yeah.net>
iyacontrol pushed a commit to iyacontrol/contour that referenced this issue Feb 23, 2021
@abhide @iyacontrol
Update usage of deprecated field FileAccessLog.json_format (projectco…
03c1050 
…ntour#3330)

Replace usage of deprecated field
envoy.extensions.access_loggers.file.v3.FileAccessLog.json_format
with
envoy.extensions.access_loggers.file.v3.FileAccessLog.log_format

Fixes: projectcontour#3210
Signed-off-by: Amey Bhide <amey15@gmail.com>
Signed-off-by: iyacontrol <gaohj2015@yeah.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhide abhide

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Update usage of deprecated field FileAccessLog.json_format abhide/contour
2 participants
@abhide @skriss