Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: change wildcard hostnames to be suffix-matching, not single segment-matching #4554

Closed
skriss opened this issue Jun 3, 2022 · 0 comments · Fixed by #4559
Closed

Gateway API: change wildcard hostnames to be suffix-matching, not single segment-matching #4554

skriss opened this issue Jun 3, 2022 · 0 comments · Fixed by #4559
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.22.0

Comments

@skriss
Copy link
Member

skriss commented Jun 3, 2022

Gateway API is changing the meaning of hostname wildcards to be prefix matching instead of single segment matching (ref. kubernetes-sigs/gateway-api#1173 (comment)). Contour has already implemented them as single segment matches, so we'll need to update. This means we don't need to use the :authority header match trick that we use for Ingress anymore for Gateway API. We'll also need to revise the Gateway<->Route hostname intersection logic.
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. labels Jun 3, 2022
@skriss skriss added this to the 1.22.0 milestone Jun 3, 2022
@skriss skriss self-assigned this Jun 6, 2022
skriss added a commit to skriss/contour that referenced this issue Jun 6, 2022
@skriss
Gateway API: allow wildcard hostnames to match more than one DNS label
9a292c3 
Changes Gateway API hostname logic to allow
wildcard hostnames to match more than one
DNS label per clarification in the upstream
spec.

Closes projectcontour#4554.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jun 6, 2022
@skriss
Gateway API: allow wildcard hostnames to match more than one DNS label
8cc9a6b 
Changes Gateway API hostname logic to allow
wildcard hostnames to match more than one
DNS label per clarification in the upstream
spec.

Closes projectcontour#4554.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Jun 6, 2022
Merged
skriss added a commit to skriss/contour that referenced this issue Jun 6, 2022
@skriss
Gateway API: allow wildcard hostnames to match more than one DNS label
1cdc2da 
Changes Gateway API hostname logic to allow
wildcard hostnames to match more than one
DNS label per clarification in the upstream
spec.

Closes projectcontour#4554.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jun 6, 2022
@skriss
Gateway API: allow wildcard hostnames to match more than one DNS label
f24c140 
Changes Gateway API hostname logic to allow
wildcard hostnames to match more than one
DNS label per clarification in the upstream
spec.

Closes projectcontour#4554.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Jun 6, 2022
Merged
skriss added a commit that referenced this issue Jun 6, 2022
@skriss
Gateway API: allow wildcard hostnames to match more than one DNS label (
b9294b6 
#4559)

Changes Gateway API hostname logic to allow
wildcard hostnames to match more than one
DNS label per clarification in the upstream
spec.

Closes #4554.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Gateway API: allow wildcard hostnames to match more than one DNS label skriss/contour
1 participant
@skriss