Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingress.kubernetes.io/force-ssl-redirect #63

Closed
davecheney opened this issue Nov 28, 2017 · 1 comment
Closed

Support ingress.kubernetes.io/force-ssl-redirect #63

davecheney opened this issue Nov 28, 2017 · 1 comment
Milestone

Comments

@davecheney
Copy link
Contributor

Add support for ingress.kubernetes.io/force-ssl-redirect per Ingress which will require creating a redirect route in the http version listener. This will need LDS to become a proper cache.

@poonai
Copy link

poonai commented Jan 14, 2018

while adding ingress, contour will check the listener cache whether the ingress domain has SSL or not. if it has SSL, contour will recompute vhost with SSL.

while adding secret, contour will check the ingress which is already present in the vhost or not. if it present, it'll recompute the vhost.

I feel that there should be some syncing mechanism for vhost in the translator.(I'm not sure)

davecheney added a commit to davecheney/contour that referenced this issue Jan 15, 2018
Fixes projectcontour#63
Closes projectcontour#146

Add support for the ingress.kubernetes.io/force-ssl-redirect: "true"
annotation

Signed-off-by: Dave Cheney <dave@cheney.net>
lrouquette added a commit to lrouquette/contour that referenced this issue Jul 13, 2021
sunjayBhatia pushed a commit that referenced this issue Jan 30, 2023
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants