Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: 0s timeout should disable the timeout #6373

Closed
skriss opened this issue Apr 23, 2024 · 2 comments · Fixed by #6375
Closed

Gateway API: 0s timeout should disable the timeout #6373

skriss opened this issue Apr 23, 2024 · 2 comments · Fixed by #6375
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/bug Categorizes issue or PR as related to a bug.
Milestone
1.29.0

Comments

@skriss
Copy link
Member

skriss commented Apr 23, 2024

ref. https://github.com/kubernetes-sigs/gateway-api/blob/v1.0.0/apis/v1/httproute_types.go#L277

ref. kubernetes-sigs/gateway-api#2823
@skriss skriss added kind/bug Categorizes issue or PR as related to a bug. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Apr 23, 2024
skriss added a commit to skriss/contour that referenced this issue Apr 23, 2024
@skriss
internal/dag: 0s HTTPRoute timeout disables the timeout
51f0c2e 
In Gateway API, a timeout specified as 0s (or any
other explicitly zero-valued duration string) should
disable the timeout rather than use the default
value.

Closes projectcontour#6373.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss mentioned this issue Apr 23, 2024
Merged
@skriss skriss self-assigned this Apr 23, 2024
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Apr 23, 2024
@skriss skriss added this to the 1.29.0 milestone Apr 23, 2024
@dprotaso dprotaso mentioned this issue Apr 23, 2024
Open
@dprotaso
Copy link

Is it possible to cherry pick this to v1.28.x (if it's convenient)?

This was referenced Apr 23, 2024
Open
Open
@skriss
Copy link
Member Author

skriss commented Apr 23, 2024

Is it possible to cherry pick this to v1.28.x (if it's convenient)?

Yeah that should be possible, we'll likely do a 1.28 patch release around the time we release 1.29 (beginning of May)

skriss added a commit that referenced this issue Apr 30, 2024
@skriss
internal/dag: 0s HTTPRoute timeout disables the timeout (#6375)
425b566 
In Gateway API, a timeout specified as 0s (or any
other explicitly zero-valued duration string) should
disable the timeout rather than use the default
value.

Closes #6373.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/bug Categorizes issue or PR as related to a bug.
Projects
Contour
Status: Done
Milestone
1.29.0
Development

Successfully merging a pull request may close this issue.

internal/dag: 0s HTTPRoute timeout disables the timeout skriss/contour
2 participants
@dprotaso @skriss