Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingress.kubernetes.io/auth-{type,secret,realm} #68

Closed
davecheney opened this issue Nov 28, 2017 · 6 comments
Closed

Support ingress.kubernetes.io/auth-{type,secret,realm} #68

davecheney opened this issue Nov 28, 2017 · 6 comments
Labels
area/ingress Issues or PRs related to the Ingress API.
Milestone

Comments

@davecheney
Copy link
Contributor

Add support for

  • ingress.kubernetes.io/auth-type
  • ingress.kubernetes.io/auth-secret
  • ingress.kubernetes.io/auth-realm

Annotations.

@domhauton
Copy link

domhauton commented Apr 28, 2018

Without this there is no (easy) way to protect ingress endpoints with oauth2.

https://eng.fromatob.com/post/2017/02/lets-encrypt-oauth-2-and-kubernetes-ingress/

@swade1987
Copy link

Would be great to have the equivalent of

nginx.ingress.kubernetes.io/auth-signin: "https://auth.oidc.example.co.uk/oauth2/start?rd=https://$host$request_uri$is_args$args"
nginx.ingress.kubernetes.io/auth-url: "https://auth.oidc.example.co.uk/oauth2/auth"

@davecheney davecheney added this to the Unplanned milestone Jun 18, 2019
@jpeach jpeach added the area/ingress Issues or PRs related to the Ingress API. label Nov 12, 2019
@sunjayBhatia
Copy link
Member

sunjayBhatia commented Dec 7, 2021

@projectcontour/maintainers superceded by #2664 ? given our investment is more in HTTPProxy and Gateway API

@travisghansen
Copy link

For anyone landing here my project now supports contour (so oauth, oidc, jwt, etc, etc). https://github.com/travisghansen/external-auth-server

@youngnick
Copy link
Member

Yes, I think this one is superseded by #2664, thanks for finding this issue.

And that's great to hear @travisghansen, thanks! Being able to look at another implementation will be very helpful for the inline filter version.

Contour Project Board automation moved this from Unprioritized to 1.20 release (candidates) Dec 9, 2021
@travisghansen
Copy link

Yeah, happy to work with you on design if it’s helpful.

sunjayBhatia pushed a commit that referenced this issue Jan 30, 2023
Fixes #68

Signed-off-by: Steve Sloka <slokas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ingress Issues or PRs related to the Ingress API.
Projects
No open projects
Contour Project Board
  
1.20 release (completed)
Development

No branches or pull requests

7 participants