Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded binding to port 8080 for listener #72

Closed
jefflaplante opened this issue Nov 30, 2017 · 1 comment
Closed

Remove hard-coded binding to port 8080 for listener #72

jefflaplante opened this issue Nov 30, 2017 · 1 comment
Assignees
@davecheney
Milestone
0.3.0

Comments

@jefflaplante
Copy link

I would like to be able to bind contour/envoy on a port other than 8080 for daemonset deployments.

https://github.com/heptio/contour/blob/b76f1c25e525837d0babd23a251dc058b7408ea4/internal/contour/json.go#L149
@davecheney davecheney added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 5, 2017
@davecheney davecheney added this to the 0.3.0 milestone Dec 5, 2017
davecheney added a commit to davecheney/contour that referenced this issue Dec 15, 2017
@davecheney
internal/contour: introduce contour.Config
9260153 
Introduce a general configuration struct to carry config information
into contour.NewTranslator().

This unblocks a lot of configuration related issues, such as projectcontour#48 and projectcontour#72

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney mentioned this issue Dec 15, 2017
Closed
@davecheney davecheney removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 19, 2017
@davecheney davecheney self-assigned this Dec 19, 2017
davecheney added a commit to davecheney/contour that referenced this issue Jan 3, 2018
@davecheney
internal/contour: make envoy-http-port configurable
f9893f7 
Fixes projectcontour#72

Introduce Translator.HTTPListenerPort and plumb it through to
--envoy-http-port.

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney mentioned this issue Jan 3, 2018
Merged
davecheney added a commit to davecheney/contour that referenced this issue Jan 3, 2018
@davecheney
internal/contour: Make https listener port configurable
bce339a 
Updates projectcontour#72

Introduce Translator.HTTPSListenerPort and plumb it through to
--envoy-https-port.
@davecheney davecheney mentioned this issue Jan 3, 2018
Merged
davecheney added a commit to davecheney/contour that referenced this issue Jan 3, 2018
@davecheney
internal/contour: Make https listener port configurable
61bf9dc 
Updates projectcontour#72

Introduce Translator.HTTPSListenerPort and plumb it through to
--envoy-https-port.

Signed-off-by: Dave Cheney <dave@cheney.net>
@jefflaplante
Copy link
Author

Awesome, thanks @davecheney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davecheney davecheney

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@davecheney @jefflaplante