makefile: Add a 'make checkall' target #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesloka
force-pushed
the
addMakeAll
branch
from
6b16011
to
3d96f82
Compare
Codecov Report
@@ Coverage Diff @@
## master #2292 +/- ##
=======================================
Coverage 77.45% 77.45%
=======================================
Files 59 59
Lines 5234 5234
=======================================
Hits 4054 4054
Misses 1092 1092
Partials 88 88Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2292 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 59 59
Lines 5237 5237
=======================================
Hits 4057 4057
Misses 1092 1092
Partials 88 88 Continue to review full report at Codecov.
|
youngnick
approved these changes
Feb 25, 2020
jpeach
approved these changes
Feb 26, 2020
Makefile
Outdated
| @@ -35,6 +35,9 @@ export GO111MODULE=on | |||
| .PHONY: check | |||
| check: install check-test check-test-race ## Install and run tests | |||
|
|
|||
| .PHONY: checkall | |||
| checkall: check lint generate generate-check | |||
There was a problem hiding this comment.
Are you sure you don't want to just bundle this up under check?
Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
addMakeAll
branch
from
3d96f82
to
49bc994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2291
This PR adds a
make checkalltask which runs the tests, install, linting and generate tasks. It's using the aliases such that as these commands grow, the meaning behind the commands doesn't have to be translated.Additionally, it renames the
check-tasks under thelinttask to be prefixed withlint-*to keep consistency.Signed-off-by: Steve Sloka slokas@vmware.com