internal/envoy: use strict DNS for resolving the cluster #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes projectcontour#228. This enable us to define the contour cluster as a DNS name. I have confirmed that `STRICT_DNS` also works when the address is an IP. As mentioned by @davecheney before, with projectcontour#158 and projectcontour#228 fixed we should be able to split Contour and Envoy into separate pods. Proof of concept: https://gist.github.com/sevein/d30e1791fbc0db786884360486e70737. Signed-off-by: Jesús García Crespo <jesus@sevein.com>
sevein
force-pushed
the
xds-cluster-dns
branch
from
c7be19e
to
f1b1bac
Compare
This was referenced May 2, 2018
Closed
sunjayBhatia
pushed a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228.
This enable us to define the contour cluster as a DNS name. I have confirmed
that
STRICT_DNSalso works when the address is an IP.As mentioned by @davecheney before, with #158 and #228 fixed we should be able
to split Contour and Envoy into separate pods. Proof of concept:
https://gist.github.com/sevein/d30e1791fbc0db786884360486e70737.
Signed-off-by: Jesús García Crespo jesus@sevein.com