Changed targetPort for httpbin pods #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2384 +/- ##
=======================================
Coverage 77.42% 77.42%
=======================================
Files 66 66
Lines 5423 5423
=======================================
Hits 4199 4199
Misses 1133 1133
Partials 91 91 Continue to review full report at Codecov.
|
stevesloka
approved these changes
Mar 25, 2020
|
@JasonMorgan could you sign the commit so we pass the DCO? |
|
Hey sorry, just seeing this, let me sign it appropriately, just did the old browser edit. |
|
Hey @JasonMorgan friendly ping if you're available to sign off your commit. Thanks! |
The containers serve up at 80, not 8080. The service gives you 503s until you make this change. Signed-off-by: Jason Morgan <jmorgan@f9vs.com>
|
Sorry about the delay! |
|
No worries, thanks @JasonMorgan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
website: fixing https://projectcontour.io/examples/httpbin.yaml so that the service serves up the httpbin site.
Didn't bother making an issue but I'm happy to if that's useful.
The containers serve traffic at 80, not 8080. The service gives you 503s until you make this change.
Signed-off-by: Jason Morgan jmorgan@pivotal.io