Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs search to the site #2458

Merged
merged 1 commit into from Apr 22, 2020
Merged

Add docs search to the site #2458

merged 1 commit into from Apr 22, 2020

Conversation

jonasrosland
Copy link
Contributor

This will add documentation search to the website.

Signed-off-by: jonasrosland jrosland@vmware.com

@jonasrosland jonasrosland added the area/website Issues or PRs related to the web site. label Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #2458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2458   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files          68       68           
  Lines        5515     5515           
=======================================
  Hits         4233     4233           
  Misses       1186     1186           
  Partials       96       96           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195ee8c...1c83f65. Read the comment docs.

@stevesloka
Copy link
Member

I wonder if we could make the search bar line up with the release version drop-down?

image

Some other things we can work on later, but noticed that the search can have duplicates:

image

Signed-off-by: jonasrosland <jrosland@vmware.com>
Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jonasrosland
Copy link
Contributor Author

I've changed the search bar to line up with the version, like this:
image

@stevesloka stevesloka merged commit 2205199 into projectcontour:master Apr 22, 2020
@jpeach jpeach added this to the 1.5.0 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website Issues or PRs related to the web site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants