internal/timeout: extract package for handling timeouts #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skriss I think this makes a lot of sense and is a great improvement. I'd like to do a full review next week. |
youngnick
suggested changes
Jul 20, 2020
skriss
force-pushed
the
refactor-timeouts
branch
from
989ba68
to
7fd56f3
Compare
jpeach
suggested changes
Jul 21, 2020
internal/timeout/timeout_test.go
Outdated
| got := Parse(tc.duration) | ||
| if tc.want != got { | ||
| t.Errorf("Wanted %v, got %v", tc.want, got) | ||
| } |
There was a problem hiding this comment.
Arguably a matter of taste, but I'd be inclined to test this like this:
assert.Equal(Parse(""), DefaultSetting())
assert.Equal(Parse("0"), DefaultSetting())I'm also OK if you want to leave this as it is.
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
refactor-timeouts
branch
from
8cd91d4
to
9ea9544
Compare
|
Rebased to address merge conflicts. |
stevesloka
approved these changes
Jul 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 76.85% 76.88% +0.03%
==========================================
Files 72 72
Lines 5702 5711 +9
==========================================
+ Hits 4382 4391 +9
Misses 1228 1228
Partials 92 92
|
This was referenced Jul 21, 2020
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
…ur#2698) Adds the internal/timeout package, which exposes a structured type for representing timeouts, and updates existing code to use this new package. Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, let me know if this makes sense. I got sick of keeping track of what -1, 0, "", and "infinity" meant between Contour and Envoy so added a proper type for it.
If this makes sense, then we can use the same package for processing the config file timeout values so the syntax is consistent everywhere.
Updates #2697