cmd/contour: add TimeoutConfig.RequestTimeout #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
force-pushed
the
move-request-timeout
branch
from
a93bab1
to
6324c7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
+ Coverage 76.98% 77.02% +0.04%
==========================================
Files 72 72
Lines 5709 5711 +2
==========================================
+ Hits 4395 4399 +4
+ Misses 1226 1225 -1
+ Partials 88 87 -1
|
skriss
added
the
release-note
youngnick
approved these changes
Jul 23, 2020
skriss
added
the
release-note-action-required
Adds a new RequestTimeout field to the TimeoutConfig struct. If specified in the config file, this field takes precedence over the now-deprecated RequestTimeout field in the root of the serveContext struct. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
move-request-timeout
branch
from
6324c7d
to
a8d8281
Compare
tthebst
pushed a commit
to tthebst/contour
that referenced
this pull request
Aug 6, 2020
Adds a new RequestTimeout field to the TimeoutConfig struct. If specified in the config file, this field takes precedence over the now-deprecated RequestTimeout field in the root of the serveContext struct. Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates #2690
Adds a new RequestTimeout field to the TimeoutConfig struct. If
specified in the config file, this field takes precedence over
the now-deprecated RequestTimeout field in the root of the
serveContext struct.
Signed-off-by: Steve Kriss krisss@vmware.com