Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/xds: Refactor xDS Server into a v2 package #3016

Merged
merged 1 commit into from Oct 9, 2020

Conversation

stevesloka
Copy link
Member

Refactors the xDS Server into a v2 package allowing for
a v3 server to be created seperate from the v2 instance.

Updates #1898

Signed-off-by: Steve Sloka slokas@vmware.com

@stevesloka stevesloka added this to the 1.10.0 milestone Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #3016 into main will increase coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3016      +/-   ##
==========================================
+ Coverage   74.47%   74.51%   +0.03%     
==========================================
  Files          92       92              
  Lines        5960     5960              
==========================================
+ Hits         4439     4441       +2     
+ Misses       1423     1422       -1     
+ Partials       98       97       -1     
Impacted Files Coverage Δ
cmd/contour/serve.go 0.00% <0.00%> (ø)
internal/xds/v2/server.go 100.00% <ø> (ø)
internal/featuretests/v2/featuretests.go 90.15% <100.00%> (ø)
internal/xds/v2/contour.go 89.28% <100.00%> (ø)
internal/dag/cache.go 96.13% <0.00%> (+0.77%) ⬆️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, just one nit.

internal/xds/contour.go Outdated Show resolved Hide resolved
Refactors the xDS Server into a v2 package allowing for
a v3 server to be created seperate from the v2 instance.

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka merged commit 8d82d40 into projectcontour:main Oct 9, 2020
@stevesloka stevesloka deleted the xdsV3Server branch October 9, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants