internal/dag: trigger rebuild for configured secrets #3191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3191 +/- ##
==========================================
- Coverage 74.14% 74.04% -0.10%
==========================================
Files 97 97
Lines 6011 6019 +8
==========================================
Hits 4457 4457
- Misses 1461 1468 +7
- Partials 93 94 +1
|
stevesloka
reviewed
Dec 9, 2020
tsaarni
force-pushed
the
issues/3190
branch
2 times, most recently
from
8291bc3
to
5c421fb
Compare
skriss
approved these changes
Dec 10, 2020
|
@tsaarni can you rebase? It looks like I can click the update branch button workflow. |
This change adds secret references from the configuration file to the list of secrets that will trigger DAG rebuild. Previously only secrets referred by HTTPProxy and Ingress resources were considered. The result was that secrets were not picked up correctly if they were created after the creation of HTTPProxy or Ingress themselves triggered a rebuild. Signed-off-by: Tero Saarni <tero.saarni@est.tech>
|
@stevesloka sure! The PR is now rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds secret references from the configuration file to the list of
secrets that will trigger DAG rebuild. Previously only secrets referred by
HTTPProxy and Ingress resources were considered. The result was that secrets
referred by fallback-certificate and envoy-client-certificate config file entries
were not picked up correctly if they were created after HTTPProxy or Ingress.
Fixes #3190
Signed-off-by: Tero Saarni tero.saarni@est.tech