Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change config/resources directory permissions 075 -> 077 #3390

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Change config/resources directory permissions 075 -> 077 #3390

merged 1 commit into from
Mar 17, 2021

Conversation

abhide
Copy link
Member

@abhide abhide commented Feb 23, 2021

Fixes: #3264
Signed-off-by: Amey Bhide amey15@gmail.com

@abhide abhide mentioned this pull request Feb 23, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 23, 2021 •
edited

Codecov Report

Merging #3390 (cfe7556) into main (2a9fb9b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
- Coverage   75.23%   75.18%   -0.05%     
==========================================
  Files          98       98              
  Lines        6586     6586              
==========================================
- Hits         4955     4952       -3     
- Misses       1519     1522       +3     
  Partials      112      112
Impacted Files Coverage Δ
internal/envoy/v3/bootstrap.go 92.26% <0.00%> (ø)
internal/k8s/log.go 63.04% <0.00%> (-6.53%) ⬇️

youngnick
youngnick suggested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks great, I think we just need a bit more documentation around why we're doing it.

internal/envoy/v3/bootstrap.go Show resolved Hide resolved
@youngnick
Copy link
Member

@abhide, are you still working on this one?

@abhide
Copy link
Member Author

abhide commented Mar 9, 2021

@abhide, are you still working on this one?

@youngnick yes, I will post an update to fix your review comment later today.

@abhide
Change config/resources directory permissions 075 -> 077
cfe7556 
Fixes: projectcontour#3264
Signed-off-by: Amey Bhide <amey15@gmail.com>
@abhide abhide marked this pull request as ready for review March 13, 2021 07:08
@abhide abhide requested a review from a team as a code owner March 13, 2021 07:08
@abhide abhide requested review from stevesloka and danehans and removed request for a team March 13, 2021 07:08
@youngnick youngnick merged commit d43ca51 into projectcontour:main Mar 17, 2021
@youngnick youngnick added this to the 1.14.0 milestone Mar 22, 2021
@youngnick youngnick added this to 1.14 release in Contour Project Board Mar 22, 2021
@youngnick youngnick added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@youngnick youngnick youngnick approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka

@danehans danehans Awaiting requested review from danehans

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

envoy container in CrashLoopBackOff : error initializing configuration
3 participants
@abhide @youngnick @sunjayBhatia