Update Service APIs references to Gateway APIs #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngnick
requested review from
stevesloka and
danehans
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 75.39% 75.42% +0.03%
==========================================
Files 98 98
Lines 6588 6588
==========================================
+ Hits 4967 4969 +2
+ Misses 1513 1512 -1
+ Partials 108 107 -1
|
|
@youngnick nit: the project should be referenced in the singular tense (Gateway API) and not plural (Gateway APIs). I think it does make sense to state that Gateway API is a group or collection of APIs or resources so the reader understands that the project is not a single API. |
Signed-off-by: Nick Young <ynick@vmware.com>
youngnick
force-pushed
the
gateway-apis-design
branch
from
c689f36
to
648f908
Compare
danehans
approved these changes
Feb 23, 2021
sunjayBhatia
requested changes
Feb 23, 2021
Signed-off-by: Nick Young <ynick@vmware.com>
sunjayBhatia
approved these changes
Feb 24, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Young ynick@vmware.com