cmd/contour: properly configure request/response headers policy #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two issues with configuring request/response headers policy. The first issue was that the user's configured request headers to set were inadvertently also being used as the response headers to set. The second issue was that some harmless empty strings were being added to the lists of request/response headers to remove. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
stevesloka and
danehans
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3519 +/- ##
=======================================
Coverage 75.63% 75.63%
=======================================
Files 98 98
Lines 6711 6711
=======================================
Hits 5076 5076
Misses 1516 1516
Partials 119 119
|
|
Per #3512 (comment) I'll have a test case covering this in that PR. |
youngnick
approved these changes
Mar 29, 2021
skriss
added
the
release-note
sunjayBhatia
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with configuring request/response headers policy.
The first issue was that the user's configured request headers to
set were inadvertently also being used as the response headers to
set. The second issue was that some harmless empty strings were
being added to the lists of request/response headers to remove.
Signed-off-by: Steve Kriss krisss@vmware.com