Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RBAC permissions for gateway-api types to allow for Status to be updated #3570

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

stevesloka
Copy link
Member

The current RBAC permissions didn't allow for status to be updated from the Contour service account. This updates those so it can write status.

Signed-off-by: Steve Sloka slokas@vmware.com

…be updated.

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 13, 2021
@stevesloka stevesloka added this to the 1.15.0 milestone Apr 13, 2021
@stevesloka stevesloka requested a review from a team as a code owner April 13, 2021 20:14
@stevesloka stevesloka requested review from danehans and youngnick and removed request for a team April 13, 2021 20:14
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #3570 (dce6468) into main (46d5ba9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3570   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files         100      100           
  Lines        6898     6898           
=======================================
  Hits         5257     5257           
  Misses       1524     1524           
  Partials      117      117           
Impacted Files Coverage Δ
internal/k8s/informers.go 0.00% <ø> (ø)

@stevesloka
Copy link
Member Author

Adding release-note tag since it changes RBAC permissions.

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skriss skriss merged commit 7c81d41 into projectcontour:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants