internal/dag: Fix processing of httproutes validation #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing through HTTPRoutes to validate if they match the configured Gateway, any additional HTTPRoutes would not get processed after the first one. This was due to an unneeded "break" in the code stopping execution for valid routes. Fixes projectcontour#3591 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
requested review from
danehans and
sunjayBhatia
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3598 +/- ##
==========================================
- Coverage 76.61% 76.61% -0.01%
==========================================
Files 100 100
Lines 7027 7026 -1
==========================================
- Hits 5384 5383 -1
Misses 1527 1527
Partials 116 116
|
danehans
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing through HTTPRoutes to validate if they match the configured Gateway,
any additional HTTPRoutes would not get processed after the first one. This was
due to an unneeded "break" in the code stopping execution for valid routes.
Fixes #3591
Signed-off-by: Steve Sloka slokas@vmware.com